biophysics.uleth.ca lists
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

us-commits

Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2021 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2020 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2019 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
us-commits@biophysics.uleth.ca

  • 6666 discussions
[ehb54/ultrascan3] 6274fe: somo/grpy: raise the exposure quadrature to 512 po...
by emre brookes Aug. 17, 2026

Aug. 17, 2026
Branch: refs/heads/somo-dev Home: https://github.com/ehb54/ultrascan3 Commit: 6274fe15b2945427c5b165214cc1ac603a418673 https://github.com/ehb54/ultrascan3/commit/6274fe15b2945427c5b165214cc1ac60… Author: Emre Brookes <emre.brookes(a)umontana.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_exposure.hpp M us_somo/develop/grpy/grpy_shell.hpp Log Message: ----------- somo/grpy: raise the exposure quadrature to 512 points per bead The exposure point pattern is generated once in the coordinate frame and applied to every bead by translation and scaling, so it does not rotate with the structure. A rigid rotation therefore changes 34-77% of bead exposures by a few of the K sample points and changes the ranking. A translation-only control is completely inert and the unreduced result is invariant to zero parts per million, so this is the quadrature, not arithmetic. The effect reaches the answer almost entirely through the stopping decision, not through which beads are kept: where the ladder stops at the same rung in every frame the reported value moves by at most 0.075%, and where the orientation flips the rung by one it moves by up to 1.043% -- a ratio of roughly fourteen, replicated on two independent grids. Measured over twelve rigid motions of six models, matched but for K: at 64, one case of eighteen changed its stopping rung and the frame-to-frame spread reached 0.23%; at 512, no case changes rung and the spread falls to 0.016%. Retained beads are unchanged (mean 31.5% vs 31.3%), and compliance and coverage are perfect at both values, so the finer quadrature costs only exposure time -- about 3% of the ladder, exposure being milliseconds against a solve of seconds. This does not make selection frame-independent; subsets still differ in nearly every frame. It makes the delivered result about 14x less sensitive to orientation, which is what matters to a user who reorients their coordinates and reruns. The low-level exposure() default stays 64 and is now annotated as such: every production caller passes K explicitly, and the shipped value is ShellOptions::K. This changes which beads are selected, so all frozen validation figures must be regenerated and the freeze tag moved. Fixes ehb54/ultrascan-tickets#984 Co-Authored-By: Claude Opus 5 <noreply(a)anthropic.com> Commit: 46d85c64e1e4ea677ea916e4ae3e671982390b2c https://github.com/ehb54/ultrascan3/commit/46d85c64e1e4ea677ea916e4ae3e6719… Author: emre brookes <ehb54(a)users.noreply.github.com> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_exposure.hpp M us_somo/develop/grpy/grpy_shell.hpp Log Message: ----------- Merge pull request #518 from ehb54/ehb54-984-quadrature somo/grpy: raise the exposure quadrature to 512 points per bead Compare: https://github.com/ehb54/ultrascan3/compare/33ba190d5897...46d85c64e1e4 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] fdf1cc: perceiver: retain the cctbx copyright notice on th...
by emre brookes Aug. 17, 2026

Aug. 17, 2026
Branch: refs/heads/ehb54-issue-980 Home: https://github.com/ehb54/ultrascan3 Commit: fdf1cc9946950fca9623060adbea5314345c8d09 https://github.com/ehb54/ultrascan3/commit/fdf1cc9946950fca9623060adbea5314… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: A us_somo/develop/perceiver/data/ref/cctbx_LICENSE.txt M us_somo/develop/perceiver/data/ref/it1992.cpp Log Message: ----------- perceiver: retain the cctbx copyright notice on the vendored it1992.cpp data/ref/it1992.cpp is a verbatim copy of cctbx's transcription of International Tables Vol. C Table 6.1.1.4, carrying none of its copyright or license. The cctbx license is BSD-style and its condition (1) requires source redistributions to retain the copyright notice, the conditions and the disclaimer. Add the notice and vendor the full license text alongside as cctbx_LICENSE.txt. The file is not compiled -- gen_saxs_entries.py parses it to generate somo.saxs_atoms entries -- but it is redistributed in source form, which is exactly what condition (1) covers. Reported-by: aaron-auc Commit: 6e2db3a595a525b590459c977fd97680bb22e7dc https://github.com/ehb54/ultrascan3/commit/6e2db3a595a525b590459c977fd97680… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/perceiver/tests/regression.cpp Log Message: ----------- perceiver: fail the regression test when it scores nothing The regression target scores against demo PDB structures that are NOT committed to the repository. read_pdb() returns an empty list for a missing file, so it scored 0 atoms, every percentage divided by zero and printed 0.000%, and it exited 0 -- reporting 'genuine perception errors remaining: 0 (0.000%)' having looked at nothing. Confirmed by running it from a clean checkout: it passed, with 0 atoms scored, on all eight demo structures. A test that reports success because it examined nothing is worse than no test. Name any input that yielded no atoms, and exit 2 when nothing was scored at all, saying that the demo structures are absent. The structures themselves are a separate call: committing them (or a fixture subset) is a data decision -- size and provenance -- not a code fix. Reported-by: aaron-auc Commit: a93e298c34721d73ee0f58b2d46848473d030e77 https://github.com/ehb54/ultrascan3/commit/a93e298c34721d73ee0f58b2d4684847… Author: emre brookes <ehb54(a)users.noreply.github.com> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: A us_somo/develop/perceiver/data/ref/cctbx_LICENSE.txt M us_somo/develop/perceiver/data/ref/it1992.cpp M us_somo/develop/perceiver/tests/regression.cpp Log Message: ----------- Merge pull request #519 from ehb54/ehb54-issue-1009-perceiver-review-fixes perceiver: cctbx notice, and stop the regression test passing on no data Compare: https://github.com/ehb54/ultrascan3/compare/fa2ad021f3ad...a93e298c3472 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] e99300: somo/grpy: report bad input and failed allocation ...
by emre brookes Aug. 17, 2026

Aug. 17, 2026
Branch: refs/heads/somo-dev Home: https://github.com/ehb54/ultrascan3 Commit: e993002a13ba1a428967d55ca1f1d4f17d85997c https://github.com/ehb54/ultrascan3/commit/e993002a13ba1a428967d55ca1f1d4f1… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_api.hpp M us_somo/develop/grpy/linalg.hpp Log Message: ----------- somo/grpy: report bad input and failed allocation instead of aborting Running GRPY in-process removed the isolation the subprocess gave it, but the module still failed like standalone code. linalg.hpp - The in-core calloc return was unchecked, so a failed allocation was followed by tile accesses through a null pointer. These are exactly the sizes that fail: this allocation is the memory wall the tiling exists for. - Out-of-core setup called std::abort() when the backing file could not be created, sized or mapped, so an unwritable or full directory killed SOMO and any unsaved work with it. Now closes and unlinks the partial file and throws, naming the path and the errno. - Both raise the new la::Error. Also widen the tile row offset before the multiply (roff()): i * b was computed in int and only then converted to Eigen::Index, which is what CodeQL flags at the six middleRows() calls. grpy_api.hpp - read_native_file() accepted every failure silently: a missing file, a truncated file or a non-numeric field all produced zeros, which became N == 0 or zero-radius beads and surfaced much later as a division by radius or a quietly meaningless result. It now validates the open, every scalar field, the declared bead count and each bead line, and rejects a non-finite coordinate or a radius that is not positive -- naming the file and line. Reported-by: aaron-auc (cherry picked from commit 1e489e741362fe17744b1b4c8dd70ab6688d94ca) Commit: e792f3dc8b2869ee86152a418da23c2d6e7399c6 https://github.com/ehb54/ultrascan3/commit/e792f3dc8b2869ee86152a418da23c2d… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/src/us_hydrodyn_grpy.cpp Log Message: ----------- somo/grpy: add a failure boundary, and let Stop reach the solve Two defects that both come from the move to an in-process solver. A failure boundary. As a subprocess a GRPY failure was isolated -- the process died, SOMO read a non-zero exit and carried on. In-process there is nothing between a throw and the application: a failed allocation, an unreadable input or a bad out-of-core path would terminate SOMO and lose the session. The parse and the whole compute now run inside a try; the catch reports the error and restores the interface exactly as the pre-flight memory guard does when it refuses a model, and in gui_script mode fails properly to stderr with a non-zero exit rather than reporting success. The body is left at its existing indentation so the diff shows the boundary and nothing else. Stop. sopt.should_stop was installed inside 'if ( sopt.enabled )', so it existed only for a shell-reduced run. With shell reduction off -- the default, and now the only configuration -- nothing was installed and Stop could not reach the solve at all: the progress callback's 'if ( stopFlag ) return;' suppresses repaints but does not end the computation, so a long model ran to completion looking hung. Install it for every run. This does not make Stop instant. A solve already running still finishes, since the factor has no interior abort; with a ladder, Stop takes effect between rungs and saves nearly all of what remained. Said plainly in the comment rather than implied. Reported-by: aaron-auc (cherry picked from commit 876a76a1fd47c75e70def12fab87b0fff40f1dce) Commit: 9f4a2289b2bfe3abb412a4681fc795235555326e https://github.com/ehb54/ultrascan3/commit/9f4a2289b2bfe3abb412a4681fc79523… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/src/us_hydrodyn_other.cpp Log Message: ----------- somo: don't let Close act during a running GRPY solve The GRPY solve runs synchronously on the GUI thread and calls processEvents() to keep the interface responsive, which also leaves Close live. Taking it would hide the window, clear the temporary directories and ask the application to quit while the solve was still running over those files -- SOMO appearing closed while it went on computing. closeEvent() now treats Close as a Stop request while grpy_running: it sets stopFlag, says that the current model must finish first because the solve cannot be interrupted part-way, and ignores the event. Closing again once it has stopped behaves normally. Reported-by: aaron-auc (cherry picked from commit 5bf6554af39173167c0b78fb1307373d4329f15e) Commit: 6325fd38e1a75ebc8fedf76bb823483a0b458f2b https://github.com/ehb54/ultrascan3/commit/6325fd38e1a75ebc8fedf76bb823483a… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_core.hpp Log Message: ----------- somo/grpy: record the GRPY provenance, copyright and citation grpy_core.hpp describes itself as a faithful translation of GRPY.f but recorded neither its author, nor its license, nor the paper to cite. Add all three: Copyright (C) 2017 Pawel Jan Zuk, GPLv3 per the GRPY.f header, and Zuk, Cichocki & Szymczak, Biophys. J. 115:782-800 (2018). The note deliberately stops short of asserting a licensing outcome. The original is GPLv3, UltraScan is LGPLv3, and a translation is a derivative work, so compatibility is a project-level decision that a source header cannot settle. Reported-by: aaron-auc Commit: 33ba190d5897186add8ed98246c862283eb3769f https://github.com/ehb54/ultrascan3/commit/33ba190d5897186add8ed98246c86228… Author: emre brookes <ehb54(a)users.noreply.github.com> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_api.hpp M us_somo/develop/grpy/grpy_core.hpp M us_somo/develop/grpy/linalg.hpp M us_somo/develop/src/us_hydrodyn_grpy.cpp M us_somo/develop/src/us_hydrodyn_other.cpp Log Message: ----------- Merge pull request #520 from ehb54/ehb54-issue-1009-somo-review-fixes somo/grpy: crash safety, working Stop, and GRPY provenance Compare: https://github.com/ehb54/ultrascan3/compare/69e372e6764e...33ba190d5897 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] e99300: somo/grpy: report bad input and failed allocation ...
by emre brookes Aug. 17, 2026

Aug. 17, 2026
Branch: refs/heads/ehb54-issue-1009-somo-review-fixes Home: https://github.com/ehb54/ultrascan3 Commit: e993002a13ba1a428967d55ca1f1d4f17d85997c https://github.com/ehb54/ultrascan3/commit/e993002a13ba1a428967d55ca1f1d4f1… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_api.hpp M us_somo/develop/grpy/linalg.hpp Log Message: ----------- somo/grpy: report bad input and failed allocation instead of aborting Running GRPY in-process removed the isolation the subprocess gave it, but the module still failed like standalone code. linalg.hpp - The in-core calloc return was unchecked, so a failed allocation was followed by tile accesses through a null pointer. These are exactly the sizes that fail: this allocation is the memory wall the tiling exists for. - Out-of-core setup called std::abort() when the backing file could not be created, sized or mapped, so an unwritable or full directory killed SOMO and any unsaved work with it. Now closes and unlinks the partial file and throws, naming the path and the errno. - Both raise the new la::Error. Also widen the tile row offset before the multiply (roff()): i * b was computed in int and only then converted to Eigen::Index, which is what CodeQL flags at the six middleRows() calls. grpy_api.hpp - read_native_file() accepted every failure silently: a missing file, a truncated file or a non-numeric field all produced zeros, which became N == 0 or zero-radius beads and surfaced much later as a division by radius or a quietly meaningless result. It now validates the open, every scalar field, the declared bead count and each bead line, and rejects a non-finite coordinate or a radius that is not positive -- naming the file and line. Reported-by: aaron-auc (cherry picked from commit 1e489e741362fe17744b1b4c8dd70ab6688d94ca) Commit: e792f3dc8b2869ee86152a418da23c2d6e7399c6 https://github.com/ehb54/ultrascan3/commit/e792f3dc8b2869ee86152a418da23c2d… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/src/us_hydrodyn_grpy.cpp Log Message: ----------- somo/grpy: add a failure boundary, and let Stop reach the solve Two defects that both come from the move to an in-process solver. A failure boundary. As a subprocess a GRPY failure was isolated -- the process died, SOMO read a non-zero exit and carried on. In-process there is nothing between a throw and the application: a failed allocation, an unreadable input or a bad out-of-core path would terminate SOMO and lose the session. The parse and the whole compute now run inside a try; the catch reports the error and restores the interface exactly as the pre-flight memory guard does when it refuses a model, and in gui_script mode fails properly to stderr with a non-zero exit rather than reporting success. The body is left at its existing indentation so the diff shows the boundary and nothing else. Stop. sopt.should_stop was installed inside 'if ( sopt.enabled )', so it existed only for a shell-reduced run. With shell reduction off -- the default, and now the only configuration -- nothing was installed and Stop could not reach the solve at all: the progress callback's 'if ( stopFlag ) return;' suppresses repaints but does not end the computation, so a long model ran to completion looking hung. Install it for every run. This does not make Stop instant. A solve already running still finishes, since the factor has no interior abort; with a ladder, Stop takes effect between rungs and saves nearly all of what remained. Said plainly in the comment rather than implied. Reported-by: aaron-auc (cherry picked from commit 876a76a1fd47c75e70def12fab87b0fff40f1dce) Commit: 9f4a2289b2bfe3abb412a4681fc795235555326e https://github.com/ehb54/ultrascan3/commit/9f4a2289b2bfe3abb412a4681fc79523… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/src/us_hydrodyn_other.cpp Log Message: ----------- somo: don't let Close act during a running GRPY solve The GRPY solve runs synchronously on the GUI thread and calls processEvents() to keep the interface responsive, which also leaves Close live. Taking it would hide the window, clear the temporary directories and ask the application to quit while the solve was still running over those files -- SOMO appearing closed while it went on computing. closeEvent() now treats Close as a Stop request while grpy_running: it sets stopFlag, says that the current model must finish first because the solve cannot be interrupted part-way, and ignores the event. Closing again once it has stopped behaves normally. Reported-by: aaron-auc (cherry picked from commit 5bf6554af39173167c0b78fb1307373d4329f15e) Commit: 6325fd38e1a75ebc8fedf76bb823483a0b458f2b https://github.com/ehb54/ultrascan3/commit/6325fd38e1a75ebc8fedf76bb823483a… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_core.hpp Log Message: ----------- somo/grpy: record the GRPY provenance, copyright and citation grpy_core.hpp describes itself as a faithful translation of GRPY.f but recorded neither its author, nor its license, nor the paper to cite. Add all three: Copyright (C) 2017 Pawel Jan Zuk, GPLv3 per the GRPY.f header, and Zuk, Cichocki & Szymczak, Biophys. J. 115:782-800 (2018). The note deliberately stops short of asserting a licensing outcome. The original is GPLv3, UltraScan is LGPLv3, and a translation is a derivative work, so compatibility is a project-level decision that a source header cannot settle. Reported-by: aaron-auc Compare: https://github.com/ehb54/ultrascan3/compare/e993002a13ba%5E...6325fd38e1a7 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] fdf1cc: perceiver: retain the cctbx copyright notice on th...
by emre brookes Aug. 17, 2026

Aug. 17, 2026
Branch: refs/heads/ehb54-issue-1009-perceiver-review-fixes Home: https://github.com/ehb54/ultrascan3 Commit: fdf1cc9946950fca9623060adbea5314345c8d09 https://github.com/ehb54/ultrascan3/commit/fdf1cc9946950fca9623060adbea5314… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: A us_somo/develop/perceiver/data/ref/cctbx_LICENSE.txt M us_somo/develop/perceiver/data/ref/it1992.cpp Log Message: ----------- perceiver: retain the cctbx copyright notice on the vendored it1992.cpp data/ref/it1992.cpp is a verbatim copy of cctbx's transcription of International Tables Vol. C Table 6.1.1.4, carrying none of its copyright or license. The cctbx license is BSD-style and its condition (1) requires source redistributions to retain the copyright notice, the conditions and the disclaimer. Add the notice and vendor the full license text alongside as cctbx_LICENSE.txt. The file is not compiled -- gen_saxs_entries.py parses it to generate somo.saxs_atoms entries -- but it is redistributed in source form, which is exactly what condition (1) covers. Reported-by: aaron-auc Commit: 6e2db3a595a525b590459c977fd97680bb22e7dc https://github.com/ehb54/ultrascan3/commit/6e2db3a595a525b590459c977fd97680… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/perceiver/tests/regression.cpp Log Message: ----------- perceiver: fail the regression test when it scores nothing The regression target scores against demo PDB structures that are NOT committed to the repository. read_pdb() returns an empty list for a missing file, so it scored 0 atoms, every percentage divided by zero and printed 0.000%, and it exited 0 -- reporting 'genuine perception errors remaining: 0 (0.000%)' having looked at nothing. Confirmed by running it from a clean checkout: it passed, with 0 atoms scored, on all eight demo structures. A test that reports success because it examined nothing is worse than no test. Name any input that yielded no atoms, and exit 2 when nothing was scored at all, saying that the demo structures are absent. The structures themselves are a separate call: committing them (or a fixture subset) is a data decision -- size and provenance -- not a code fix. Reported-by: aaron-auc Compare: https://github.com/ehb54/ultrascan3/compare/fdf1cc994695%5E...6e2db3a595a5 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] 7e35c3: somo: record the provenance of the vendored cctbx ...
by emre brookes Aug. 17, 2026

Aug. 17, 2026
Branch: refs/heads/ehb54-issue-1009-somo-merge Home: https://github.com/ehb54/ultrascan3 Commit: 7e35c33cbdc5135f8b5525b30f85734204df411b https://github.com/ehb54/ultrascan3/commit/7e35c33cbdc5135f8b5525b30f857342… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_core.hpp A us_somo/develop/perceiver/data/ref/cctbx_LICENSE.txt M us_somo/develop/perceiver/data/ref/it1992.cpp Log Message: ----------- somo: record the provenance of the vendored cctbx and GRPY sources Two files carry third-party origin that was not recorded. perceiver/data/ref/it1992.cpp is a verbatim copy of cctbx's transcription of International Tables Vol. C Table 6.1.1.4. The cctbx license is BSD-style and its condition (1) requires source redistributions to retain the copyright notice, the conditions and the disclaimer; none of that was present. Add the notice and vendor the full license text alongside as cctbx_LICENSE.txt. The file is not compiled -- gen_saxs_entries.py parses it -- but it is redistributed in source form, which is exactly what condition (1) covers. grpy/grpy_core.hpp describes itself as a faithful translation of GRPY.f but recorded neither its author nor its license nor the paper to cite. Add all three: Copyright (C) 2017 Pawel Jan Zuk, GPLv3 per the GRPY.f header, and the Biophys. J. 115:782-800 (2018) reference. The GRPY note deliberately stops short of asserting a licensing outcome. The original is GPLv3, UltraScan is LGPLv3, and a translation is a derivative work, so compatibility is a project-level decision and not something a source header can settle. Flagged in the header and raised on the ticket. Reported-by: aaron-auc Commit: 1e489e741362fe17744b1b4c8dd70ab6688d94ca https://github.com/ehb54/ultrascan3/commit/1e489e741362fe17744b1b4c8dd70ab6… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_api.hpp M us_somo/develop/grpy/linalg.hpp Log Message: ----------- somo/grpy: report bad input and failed allocation instead of aborting Running GRPY in-process removed the isolation the subprocess gave it, but the module still failed like standalone code. linalg.hpp - The in-core calloc return was unchecked, so a failed allocation was followed by tile accesses through a null pointer. These are exactly the sizes that fail: this allocation is the memory wall the tiling exists for. - Out-of-core setup called std::abort() when the backing file could not be created, sized or mapped, so an unwritable or full directory killed SOMO and any unsaved work with it. Now closes and unlinks the partial file and throws, naming the path and the errno. - Both raise the new la::Error. Also widen the tile row offset before the multiply (roff()): i * b was computed in int and only then converted to Eigen::Index, which is what CodeQL flags at the six middleRows() calls. grpy_api.hpp - read_native_file() accepted every failure silently: a missing file, a truncated file or a non-numeric field all produced zeros, which became N == 0 or zero-radius beads and surfaced much later as a division by radius or a quietly meaningless result. It now validates the open, every scalar field, the declared bead count and each bead line, and rejects a non-finite coordinate or a radius that is not positive -- naming the file and line. Reported-by: aaron-auc Commit: 876a76a1fd47c75e70def12fab87b0fff40f1dce https://github.com/ehb54/ultrascan3/commit/876a76a1fd47c75e70def12fab87b0ff… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/src/us_hydrodyn_grpy.cpp Log Message: ----------- somo/grpy: add a failure boundary, and let Stop reach the solve Two defects that both come from the move to an in-process solver. A failure boundary. As a subprocess a GRPY failure was isolated -- the process died, SOMO read a non-zero exit and carried on. In-process there is nothing between a throw and the application: a failed allocation, an unreadable input or a bad out-of-core path would terminate SOMO and lose the session. The parse and the whole compute now run inside a try; the catch reports the error and restores the interface exactly as the pre-flight memory guard does when it refuses a model, and in gui_script mode fails properly to stderr with a non-zero exit rather than reporting success. The body is left at its existing indentation so the diff shows the boundary and nothing else. Stop. sopt.should_stop was installed inside 'if ( sopt.enabled )', so it existed only for a shell-reduced run. With shell reduction off -- the default, and now the only configuration -- nothing was installed and Stop could not reach the solve at all: the progress callback's 'if ( stopFlag ) return;' suppresses repaints but does not end the computation, so a long model ran to completion looking hung. Install it for every run. This does not make Stop instant. A solve already running still finishes, since the factor has no interior abort; with a ladder, Stop takes effect between rungs and saves nearly all of what remained. Said plainly in the comment rather than implied. Reported-by: aaron-auc Commit: 5bf6554af39173167c0b78fb1307373d4329f15e https://github.com/ehb54/ultrascan3/commit/5bf6554af39173167c0b78fb1307373d… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/src/us_hydrodyn_other.cpp Log Message: ----------- somo: don't let Close act during a running GRPY solve The GRPY solve runs synchronously on the GUI thread and calls processEvents() to keep the interface responsive, which also leaves Close live. Taking it would hide the window, clear the temporary directories and ask the application to quit while the solve was still running over those files -- SOMO appearing closed while it went on computing. closeEvent() now treats Close as a Stop request while grpy_running: it sets stopFlag, says that the current model must finish first because the solve cannot be interrupted part-way, and ignores the event. Closing again once it has stopped behaves normally. Reported-by: aaron-auc Commit: 10096f5718f75915e929d7cdcd904a53735ead44 https://github.com/ehb54/ultrascan3/commit/10096f5718f75915e929d7cdcd904a53… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/src/us_hydrodyn_save.cpp Log Message: ----------- somo: drop the held-back shell-reduction columns from the Save dialog Shell reduction is hidden and forced off, but its six columns stayed in the Save-parameters field list, offering settings that cannot be changed and results that are always zero or empty. Comment them out in both field lists, with a marker pointing at grpy_shell_released. The field handlers below are left in place: they are keyed off the list, so they are simply never reached, and they are needed as-is when the feature is released. This commit is specific to holding the feature back and should not be carried upstream to somo-dev, where shell reduction is live. Reported-by: aaron-auc Commit: 83dab3feb53857c5100b5af13d14c844d79088b1 https://github.com/ehb54/ultrascan3/commit/83dab3feb53857c5100b5af13d14c844… Author: ehb54 <brookes(a)uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: A .github/workflows/somo-module-tests.yml M us_somo/develop/perceiver/tests/regression.cpp Log Message: ----------- somo: run the grpy and perceiver suites in CI, and stop the regression test passing vacuously The numerical suites were only ever run by hand, so a change could pass CI while breaking the behaviour they cover. While wiring them up, the perceiver regression target turned out to be worse than unrun: it scores against demo PDB structures that are NOT committed to the repository. read_pdb() returns an empty list for a missing file, so it scored 0 atoms, every percentage divided by zero and printed 0.000%, and it exited 0 -- reporting 'genuine perception errors remaining: 0 (0.000%)' having looked at nothing. Verified by running it: it passed with 0 atoms scored. - regression.cpp now names any input that yielded no atoms, and fails (exit 2) when it scored nothing at all, explaining that the demo structures are absent. - New workflow runs the grpy suite and the perceiver unit tests, both Qt-free and standalone against the vendored Eigen. It also asserts the vacuous-pass guard itself: with no input, bin/regression must fail. The regression target proper stays out of CI until it has structures to score. Committing the demo set (or a fixture subset) is a separate call -- it is data, and its size and provenance are worth deciding deliberately. Reported-by: aaron-auc Compare: https://github.com/ehb54/ultrascan3/compare/0465d69edc58...83dab3feb538 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] 6274fe: somo/grpy: raise the exposure quadrature to 512 po...
by emre brookes Aug. 17, 2026

Aug. 17, 2026
Branch: refs/heads/ehb54-984-quadrature Home: https://github.com/ehb54/ultrascan3 Commit: 6274fe15b2945427c5b165214cc1ac603a418673 https://github.com/ehb54/ultrascan3/commit/6274fe15b2945427c5b165214cc1ac60… Author: Emre Brookes <emre.brookes(a)umontana.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_exposure.hpp M us_somo/develop/grpy/grpy_shell.hpp Log Message: ----------- somo/grpy: raise the exposure quadrature to 512 points per bead The exposure point pattern is generated once in the coordinate frame and applied to every bead by translation and scaling, so it does not rotate with the structure. A rigid rotation therefore changes 34-77% of bead exposures by a few of the K sample points and changes the ranking. A translation-only control is completely inert and the unreduced result is invariant to zero parts per million, so this is the quadrature, not arithmetic. The effect reaches the answer almost entirely through the stopping decision, not through which beads are kept: where the ladder stops at the same rung in every frame the reported value moves by at most 0.075%, and where the orientation flips the rung by one it moves by up to 1.043% -- a ratio of roughly fourteen, replicated on two independent grids. Measured over twelve rigid motions of six models, matched but for K: at 64, one case of eighteen changed its stopping rung and the frame-to-frame spread reached 0.23%; at 512, no case changes rung and the spread falls to 0.016%. Retained beads are unchanged (mean 31.5% vs 31.3%), and compliance and coverage are perfect at both values, so the finer quadrature costs only exposure time -- about 3% of the ladder, exposure being milliseconds against a solve of seconds. This does not make selection frame-independent; subsets still differ in nearly every frame. It makes the delivered result about 14x less sensitive to orientation, which is what matters to a user who reorients their coordinates and reruns. The low-level exposure() default stays 64 and is now annotated as such: every production caller passes K explicitly, and the shipped value is ShellOptions::K. This changes which beads are selected, so all frozen validation figures must be regenerated and the freeze tag moved. Fixes ehb54/ultrascan-tickets#984 Co-Authored-By: Claude Opus 5 <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] 9a101a: Fail the Qt5 unit-test step on a broken build inst...
by aaron-auc Aug. 16, 2026

Aug. 16, 2026
Branch: refs/heads/test-data-synthetic-generator Home: https://github.com/ehb54/ultrascan3 Commit: 9a101a70a60c1ce0abd0d7696f7ff56444ca8006 https://github.com/ehb54/ultrascan3/commit/9a101a70a60c1ce0abd0d7696f7ff564… Author: aaron-auc <aaron(a)aucsolutions.com> Date: 2026-08-16 (Sun, 16 Aug 2026) Changed paths: M .github/workflows/unit-tests-qt5-v2.yml Log Message: ----------- Fail the Qt5 unit-test step on a broken build instead of reporting tee's success To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] 87af42: Run the Qt6 unit-test steps under bash so PIPESTAT...
by aaron-auc Aug. 16, 2026

Aug. 16, 2026
Branch: refs/heads/test-data-synthetic-generator Home: https://github.com/ehb54/ultrascan3 Commit: 87af42a053103dcc73f29a5e56ca2f5b21e62cc0 https://github.com/ehb54/ultrascan3/commit/87af42a053103dcc73f29a5e56ca2f5b… Author: aaron-auc <aaron(a)aucsolutions.com> Date: 2026-08-16 (Sun, 16 Aug 2026) Changed paths: M .github/workflows/unit-tests-qt6-v2.yml Log Message: ----------- Run the Qt6 unit-test steps under bash so PIPESTATUS parses and a failing build is not masked by tee To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
[ehb54/ultrascan3] f7972a: Split the unit-test workflow into Qt5 and Qt6 vari...
by aaron-auc Aug. 16, 2026

Aug. 16, 2026
Branch: refs/heads/test-data-synthetic-generator Home: https://github.com/ehb54/ultrascan3 Commit: f7972a40f6763054144491295bfcfd9f772908da https://github.com/ehb54/ultrascan3/commit/f7972a40f6763054144491295bfcfd9f… Author: aaron-auc <aaron(a)aucsolutions.com> Date: 2026-08-16 (Sun, 16 Aug 2026) Changed paths: A .github/workflows/unit-tests-qt5-v2.yml A .github/workflows/unit-tests-qt6-v2.yml R .github/workflows/unit-tests-v2.yml Log Message: ----------- Split the unit-test workflow into Qt5 and Qt6 variants so the suite runs under both To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 106
  • 107
  • 108
  • 109
  • 110
  • 111
  • 112
  • ...
  • 667
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.