[ehb54/ultrascan3] 1c8f71: somo/grpy: keep the finished rungs when Stop lands...
Branch: refs/heads/ehb54-issue-1012 Home: https://github.com/ehb54/ultrascan3 Commit: 1c8f71ee1670dd0bb052e04232baea6b3a3c3b74 https://github.com/ehb54/ultrascan3/commit/1c8f71ee1670dd0bb052e04232baea6b3... Author: ehb54 <brookes@uthscsa.edu> Date: 2026-08-17 (Mon, 17 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_process.hpp M us_somo/develop/grpy/grpy_shell.hpp M us_somo/develop/grpy/grpy_types.hpp M us_somo/develop/grpy/tests/test_shell.cpp M us_somo/somo/doc/manual/somo/somo_hydro.html M us_somo/somo/doc/manual/somo/somo_misc.html Log Message: ----------- somo/grpy: keep the finished rungs when Stop lands mid-calculation, and correct the manual Updating the manual turned up a regression rather than just stale prose. somo_hydro.html promises that a stopped shell reduction 'keeps the result and error estimate obtained so far'. That held while GRPY ran in process, because it could only be stopped between rungs. A separate program can be killed the instant Stop is pressed -- which is the improvement -- but the exception was propagating straight past the ladder, discarding every rung that had already completed. The promise in the manual was no longer true of the code. ShellSolver now treats a stop during a rung exactly as it treats one between rungs: the ladder ends where it stands, reports itself as not converged, and keeps its result and its error bar. Only a stop before the first rung has finished leaves nothing to report, and that one still propagates. grpy::Stopped moved from grpy_process.hpp to grpy_types.hpp so the ladder can catch it without acquiring a Qt dependency. Two tests pin it: a solver that stops during the third rung must leave two usable rungs with a bar, and one that stops immediately must propagate. Manual: * somo_misc.html said GRPY is 'built directly into US-SOMO and runs multi-core in-process'. It is again a separate multi-core program, which US-SOMO installs and runs; no Docker image and no checkbox, as before. The historical sentence about the original external and Docker versions is left as it stands, being history. * somo_hydro.html said Stop ends the series 'at the end of the calculation currently in progress'. It now ends immediately, per the change above. Refs ehb54/ultrascan-tickets#1012 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
participants (1)
-
emre brookes