[ehb54/ultrascan3] 45e44d: somo/grpy: brace three bodies the style tool did n...
Branch: refs/heads/ehb54-issue-1016-somo-merge-2 Home: https://github.com/ehb54/ultrascan3 Commit: 45e44d2afe8e2e00ac5443f50cc1de61539b2487 https://github.com/ehb54/ultrascan3/commit/45e44d2afe8e2e00ac5443f50cc1de615... Author: ehb54 <brookes@uthscsa.edu> Date: 2026-08-18 (Tue, 18 Aug 2026) Changed paths: M us_somo/develop/grpy/tests/test_shell.cpp Log Message: ----------- somo/grpy: brace three bodies the style tool did not catch Answering "does this branch conform": it did not, in three places, all in test_shell.cpp and all added by this set. for ( size_t i : ref ) ref_xyz.push_back( {c[ i ].x, ... } ); for ( size_t i : got ) got_xyz.push_back( {pc[ i ].x, ... } ); if ( r ) for ( int k : rep.kept[ r - 1 ] ) us3_style.pl reported 0 violations on these files, which is why they survived the earlier pass. Two blind spots in its --check: - it treats ANY '{' on the line as "already opens a body", so an unbraced body whose argument is a braced initializer list looks braced; - its inline case requires the body to end in ';', so a body that is itself a control statement (`if ( r ) for ( ... )`) matches nothing. Found by cross-checking with a second checker rather than trusting one tool. Both blind spots are being fixed upstream in ehb54/grpy-cpp#1. Swept every line this branch adds with the stricter check afterwards: 0 unbraced bodies remain. grpy tests still ALL PASS. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
participants (1)
-
emre brookes