[ehb54/ultrascan3] 5114b2: perceiver: fix the review dialog never appearing f...
Branch: refs/heads/ehb54-issue-980 Home: https://github.com/ehb54/ultrascan3 Commit: 5114b24f2ef3fa0342811242c80706b0cd926912 https://github.com/ehb54/ultrascan3/commit/5114b24f2ef3fa0342811242c80706b0c... Author: ehb54 <brookes@uthscsa.edu> Date: 2026-08-09 (Sun, 09 Aug 2026) Changed paths: M us_somo/develop/perceiver/tests/dialog_qt.cpp M us_somo/develop/src/us_hydrodyn.cpp M us_somo/develop/src/us_hydrodyn_perceive_dialog.cpp Log Message: ----------- perceiver: fix the review dialog never appearing from the GUI menu Lookup Tables -> Perceive Non-Coded Residues... appeared to do nothing: the dialog was constructed as a CHILD WIDGET of the main window, not as a window. A QFrame given a parent and no window flag is an ordinary child, so setWindowTitle and setWindowModality were silently ignored and the setGeometry( x, y, 0, 0 ) idiom the other 116 SOMO dialogs use -- which a window manager expands to the layout minimum -- left it 0 x 0, positioned by a screen-coordinate global inside (and clipped by) the parent. The caller then waited on isVisible(), which for a child never goes false, so SOMO sat in the wait loop with nothing on screen. Measured, with the dialog built the way the slot builds it: before isWindow 0, 0 x 0 after isWindow 1, 1154 x 718 Every other SOMO dialog avoids this by passing no parent at all. Keeping the parent and adding Qt::Window is better on macOS: the dialog then also stays stacked above its owner. Adds fixWinButtons/raise/activateWindow to match what the other dialogs do on show. Also make the slot incapable of failing silently again: every exit path now writes to the text window, including both "nothing to do" cases, and the message boxes get a parent so they cannot open behind the main window. dialog_qt.cpp gained the check that catches this -- it constructed the dialog with no parent, i.e. exactly the case that works. Building it with a parent and asserting isWindow() plus a non-degenerate size after show() reproduces the failure offscreen (3 failures on the old code, 21/21 on the new). To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
participants (1)
-
emre brookes