[ehb54/ultrascan3] b79db6: Fix Windows/MinGW build: std::byte vs rpcndr.h byt...
Branch: refs/heads/lukas/theme-fixes Home: https://github.com/ehb54/ultrascan3 Commit: b79db6ebbbcc6df95babf034d1f7372ec746c623 https://github.com/ehb54/ultrascan3/commit/b79db6ebbbcc6df95babf034d1f7372ec... Author: ehb54 <brookes@uthscsa.edu> Date: 2026-08-19 (Wed, 19 Aug 2026) Changed paths: M us_somo/develop/include/us_hydrodyn_perceive_dialog.h Log Message: ----------- Fix Windows/MinGW build: std::byte vs rpcndr.h byte ambiguity moc_us_hydrodyn_perceive_dialog.cpp failed to compile under MSYS2/MinGW64 with ~40 "reference to byte is ambiguous" errors from the Win32 SDK headers. us_hydrodyn_perceive_somo.h reaches us_hydrodyn_pdbdefs.h, whose "using namespace std;" makes std::byte visible unqualified. us_util.h then pulls in windows.h via us.h -> QtWidgets -> qopengl.h -> qt_windows.h, and rpcndr.h typedefs a global "byte", so every subsequent use is ambiguous. Including us_util.h first parses windows.h before the using-directive is in scope, which is the order every other SOMO header already follows (see us_hydrodyn.h, us.h at line 29 ahead of us_hydrodyn_pdbdefs.h at line 35). The .cpp was unaffected because it includes us3_defines.h first; only the moc translation unit, which includes the header bare, hit the error. Ref ehb54/ultrascan-tickets#1022 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Commit: e235c2d5b3f5800f7831622b920971a1e5dfcc0a https://github.com/ehb54/ultrascan3/commit/e235c2d5b3f5800f7831622b920971a1e... Author: emre brookes <ehb54@users.noreply.github.com> Date: 2026-08-19 (Wed, 19 Aug 2026) Changed paths: M us_somo/develop/include/us_hydrodyn_perceive_dialog.h Log Message: ----------- Merge pull request #529 from ehb54/ehb54-issue-1022 Fix Windows/MinGW build: std::byte vs rpcndr.h byte ambiguity in perceive dialog header Commit: 541ee619eefc3ce6c914f427300b34e325e1b9bb https://github.com/ehb54/ultrascan3/commit/541ee619eefc3ce6c914f427300b34e32... Author: Lukas Dobler <69309597+doluk@users.noreply.github.com> Date: 2026-08-19 (Wed, 19 Aug 2026) Changed paths: M us_somo/develop/include/us_hydrodyn_perceive_dialog.h Log Message: ----------- Merge branch 'main' into lukas/theme-fixes Compare: https://github.com/ehb54/ultrascan3/compare/c32962f2eaf6...541ee619eefc To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
participants (1)
-
Lukas Dobler