[ehb54/us3lims_common] cb2e54: Classify sbatch's final verdict line only, so an i...
Branch: refs/heads/ehb54-issue-478 Home: https://github.com/ehb54/us3lims_common Commit: cb2e54bbf9f004e03aa6e28cf3f050a701b47efd https://github.com/ehb54/us3lims_common/commit/cb2e54bbf9f004e03aa6e28cf3f05... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-06 (Tue, 06 Oct 2026) Changed paths: M class/remote_exec.php Log Message: ----------- Classify sbatch's final verdict line only, so an internal EAGAIN retry that later succeeds is no longer misclassified as a definite rejection and resubmitted Commit: 062c5ba488e29c5ab1aede71af0f76a4fff7b43f https://github.com/ehb54/us3lims_common/commit/062c5ba488e29c5ab1aede71af0f7... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-06 (Tue, 06 Oct 2026) Changed paths: M class/remote_exec.php M global_config.php.template Log Message: ----------- Fix the ControlPath length ceiling and root-owned-directory check, refuse a control dir containing space or %, fall back to a plain connection on a control-socket-specific failure, and correct stale documentation/comments Commit: 3357090d034d88ebd5b80a85379ab0b43f50c833 https://github.com/ehb54/us3lims_common/commit/3357090d034d88ebd5b80a85379ab... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-06 (Tue, 06 Oct 2026) Changed paths: M global_config.php.template Log Message: ----------- Document dbinst#75's global_elog_dir override and its cross-account provisioning in the shared template Commit: f50a973331b8eccb20e1063e146b4e59248894ce https://github.com/ehb54/us3lims_common/commit/f50a973331b8eccb20e1063e146b4... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-06 (Tue, 06 Oct 2026) Changed paths: M class/remote_exec.php Log Message: ----------- Add a breaker_gate option to skip only the open-breaker refusal, keeping bookkeeping, for a caller with fresher evidence than the breaker Commit: 74e8c3bb242a3be32d479a26f020796acf1a066b https://github.com/ehb54/us3lims_common/commit/74e8c3bb242a3be32d479a26f0207... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-07 (Wed, 07 Oct 2026) Changed paths: M global_config.php.template Log Message: ----------- Remove the global_elog_dir setting: elog() always logs to the hardcoded default regardless of it, so offering it as a deployment knob was actively misleading Commit: 1076a1019cf28defce7a3eb61a03c9e524a59465 https://github.com/ehb54/us3lims_common/commit/1076a1019cf28defce7a3eb61a03c... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-07 (Wed, 07 Oct 2026) Changed paths: M class/remote_exec.php M class/submit_slurm.php M global_config.php.template Log Message: ----------- Test the control-socket fallback before the retry-budget break so it also applies with retries=>0, recognize OpenSSH's denied link() as a control-socket failure, classify a REMOTE_FAIL sbatch rejection the same way as an UNREACHABLE one, and fix two stale template claims Commit: 0b99f3753ebe6daf0b472e41d1e09eb7563da731 https://github.com/ehb54/us3lims_common/commit/0b99f3753ebe6daf0b472e41d1e09... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-07 (Wed, 07 Oct 2026) Changed paths: M class/remote_exec.php Log Message: ----------- Disambiguate sbatch's own 255 exit from ssh's transport-failure 255 via the end marker, add '=' and '"' to the ControlPath character check and move it before the mkdir, and single-line the fallback log entry Commit: a3424dbe6a65ab9cf28120ae36083d8daaa2c9cd https://github.com/ehb54/us3lims_common/commit/a3424dbe6a65ab9cf28120ae36083... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-07 (Wed, 07 Oct 2026) Changed paths: M class/remote_exec.php Log Message: ----------- Add an overridable test seam for the root-owned-directory branch in controlPath(), so it no longer needs a real privilege boundary to exercise Commit: b18fab357b6658c82465bcb7c7c594748c002bc1 https://github.com/ehb54/us3lims_common/commit/b18fab357b6658c82465bcb7c7c59... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-07 (Wed, 07 Oct 2026) Changed paths: M class/remote_exec.php M class/submit_slurm.php M global_config.php.template Log Message: ----------- Require the begin marker and the end marker's own exit status before trusting a plain-connection fallback or a 255 as transport failure Commit: 2e63aa5336dee92ae009b97cfe85bdc178c33e58 https://github.com/ehb54/us3lims_common/commit/2e63aa5336dee92ae009b97cfe85b... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-07 (Wed, 07 Oct 2026) Changed paths: M class/remote_exec.php Log Message: ----------- Scope the mux-unusable/control-directory-warning memory to the instance instead of the process, so it cannot leak between unrelated remote_exec objects Commit: 89667122779d17d261b6b280007b396ce07a28a7 https://github.com/ehb54/us3lims_common/commit/89667122779d17d261b6b280007b3... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-08 (Thu, 08 Oct 2026) Changed paths: M class/remote_exec.php M class/submit_slurm.php M global_config.php.template Log Message: ----------- Narrow scheduler-rejection matching to connect-failures only, give sbatch a timeout above its own retry loop, run commands locally without ssh for localhost clusters, cache one remote_exec per cluster, and fix the ControlPath whitelist and end-marker matching to anchor at end of line Commit: c56a38a45b7c6c7176e9627e8298b840a8defa42 https://github.com/ehb54/us3lims_common/commit/c56a38a45b7c6c7176e9627e8298b... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-09 (Fri, 09 Oct 2026) Changed paths: M class/remote_exec.php Log Message: ----------- Run the local-exec branch's framed command through /bin/sh -c so its timeout and stderr redirect apply to the whole script, not just its first line Commit: c4493df73742197ddd826190d21188d78229ccb8 https://github.com/ehb54/us3lims_common/commit/c4493df73742197ddd826190d2118... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-09 (Fri, 09 Oct 2026) Changed paths: M class/remote_exec.php M global_config.php.template Log Message: ----------- Also treat the cluster named by $default_local_cluster as local, and set that variable by default in the template, so a fresh install's co-located cluster runs locally too Commit: 78dc3c33eaa3bc63e7ee5cf9fd76f030fa354b28 https://github.com/ehb54/us3lims_common/commit/78dc3c33eaa3bc63e7ee5cf9fd76f... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-09 (Fri, 09 Oct 2026) Changed paths: M class/remote_exec.php M class/submit_slurm.php Log Message: ----------- Validate sbatch_timeout_seconds and never let it shorten a cluster's own command_timeout_seconds override, fix the scheduler-verdict regex list and anchor it to sbatch's last line, recognize two more busy verdicts, widen end-marker anchoring for CRLF and trailing blanks, stop reporting a timed-out call's exit code as the marker's, prioritize a breaker-open refusal's wording over sbatch-never-started, and fix stale comments Commit: 3beb8218d0b5b3994166a7c66b4f735222c3ff4d https://github.com/ehb54/us3lims_common/commit/3beb8218d0b5b3994166a7c66b4f7... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-09 (Fri, 09 Oct 2026) Changed paths: M class/remote_exec.php M class/submit_slurm.php Log Message: ----------- Drop review-round labels from comments, keeping only the engineering rationale Commit: 3f0e0c8fcaaed86530bc3f87ae1ee8af287c205c https://github.com/ehb54/us3lims_common/commit/3f0e0c8fcaaed86530bc3f87ae1ee... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-10 (Sat, 10 Oct 2026) Changed paths: M class/remote_exec.php Log Message: ----------- Require the entry's login host to actually match this machine before $default_local_cluster's name match alone sends a command through the local-exec path, so a remote cluster whose login happens to share this host's account name no longer runs commands locally Commit: 7235b3d8e0bf0c7aaab7aba98dbcc14898fa479f https://github.com/ehb54/us3lims_common/commit/7235b3d8e0bf0c7aaab7aba98dbcc... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-10 (Sat, 10 Oct 2026) Changed paths: M class/remote_exec.php M class/submit_slurm.php M global_config.php.template Log Message: ----------- Anchor is_scheduler_busy() to the last submission-failure line, make an explicit 'localhost' => false actually opt out and log the fallback same as a default_local_cluster host mismatch, redirect the local branch's stdin from /dev/null, fix the stale three-connections/scontrol-confirm comments, and drop the remaining review-round labels Commit: 59a3b7754ae7e7632cc8abe9c8545069d69f3b17 https://github.com/ehb54/us3lims_common/commit/59a3b7754ae7e7632cc8abe9c8545... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-10 (Sat, 10 Oct 2026) Changed paths: M class/circuit_breaker.php M class/remote_exec.php Log Message: ----------- Shrink the in-call transport retry budget to one and make the circuit breaker's cooldown double on each consecutive trip up to a configurable ceiling Commit: 49e5792680246c00fd22b8f0a4696d5606c12754 https://github.com/ehb54/us3lims_common/commit/49e5792680246c00fd22b8f0a4696... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-11 (Sun, 11 Oct 2026) Changed paths: M contacts.php Log Message: ----------- Remove Gary Gorbet's personal contact info from the public contacts page Commit: accd73455e4d8ea70f05a91b96cdf0d5883802e7 https://github.com/ehb54/us3lims_common/commit/accd73455e4d8ea70f05a91b96cdf... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-11 (Sun, 11 Oct 2026) Changed paths: M class/circuit_breaker.php M class/remote_exec.php M class/submit_slurm.php M global_config.php.template Log Message: ----------- Merge updated branch '780-request-pbs-gfac-cleanup' into this branch's own Gary Gorbet contacts.php fix Commit: fc5a3337e13131df399925132b7932eb69fc367d https://github.com/ehb54/us3lims_common/commit/fc5a3337e13131df399925132b793... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-11 (Sun, 11 Oct 2026) Changed paths: M class/circuit_breaker.php M class/remote_exec.php M class/submit_slurm.php Log Message: ----------- Mail the investigator on every failed autoflow submission and the admin once per circuit-breaker outage, instead of mailing no one Commit: d6f7f7f046125ef8564027898e4af41756a98304 https://github.com/ehb54/us3lims_common/commit/d6f7f7f046125ef8564027898e4af... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-11 (Sun, 11 Oct 2026) Changed paths: M class/submit_slurm.php Log Message: ----------- Cast the autoflow requestID to int before interpolating it into SQL, fixing SonarCloud's quality-gate flag on the new email lookup Commit: af17dad3ad239492199c2c659a334d017203662a https://github.com/ehb54/us3lims_common/commit/af17dad3ad239492199c2c659a334... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-11 (Sun, 11 Oct 2026) Changed paths: M class/submit_slurm.php Log Message: ----------- Use a prepared statement for the investigator email lookup to satisfy SonarCloud's SQL-formatting rule Commit: 405e4d85638d18f27a2b52ae6b6dac6a7c9f173d https://github.com/ehb54/us3lims_common/commit/405e4d85638d18f27a2b52ae6b6da... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-12 (Mon, 12 Oct 2026) Changed paths: M class/circuit_breaker.php M class/remote_exec.php M class/submit_slurm.php M global_config.php.template Log Message: ----------- Harden circuit breaker validation and late-failure handling, decide cluster locality only by an explicit flag, and override the breaker's max cooldown from global_config Commit: 3920254174249eda176cd49aacd5b69749662b88 https://github.com/ehb54/us3lims_common/commit/3920254174249eda176cd49aacd5b... Author: aaron-auc <aaron@aucsolutions.com> Date: 2026-10-12 (Mon, 12 Oct 2026) Changed paths: M class/circuit_breaker.php M class/remote_exec.php M class/submit_slurm.php M contacts.php M global_config.php.template Log Message: ----------- Merge remote-tracking branch 'origin/780-request-pbs-gfac-cleanup' into ehb54-issue-478-local Compare: https://github.com/ehb54/us3lims_common/compare/b9496a9542e4...392025417424 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/us3lims_common/settings/notifications
participants (1)
-
aaron-auc