[us-commits] [ehb54/ultrascan3] 8f8305: Fix incorrect shortcut for "Save As" action in US ...

Lukas Dobler noreply at github.com
Wed Jun 18 03:51:58 MDT 2025


  Branch: refs/heads/lukas/us_fematch
  Home:   https://github.com/ehb54/ultrascan3
  Commit: 8f830525885db00bd4da5e1a33245885e8d7f3dc
      https://github.com/ehb54/ultrascan3/commit/8f830525885db00bd4da5e1a33245885e8d7f3dc
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_editor.cpp

  Log Message:
  -----------
  Fix incorrect shortcut for "Save As" action in US Editor

Adjusted the shortcut from "Ctrl+A" to the correct "Ctrl+S" for consistency with common usage and intended functionality.


  Commit: fc7c8b55767ae2d0206cc1b806ce26a3e1cdaa5a
      https://github.com/ehb54/ultrascan3/commit/fc7c8b55767ae2d0206cc1b806ce26a3e1cdaa5a
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_editor.cpp

  Log Message:
  -----------
  Updated `QFileDialog::getSaveFileName` to include parameters for title, directory, and file extension, improving user experience and consistency.


  Commit: 5b8446fec26727278afd3ae8f1f331917919a98f
      https://github.com/ehb54/ultrascan3/commit/5b8446fec26727278afd3ae8f1f331917919a98f
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_editor.cpp

  Log Message:
  -----------
  Update `saveFile` to handle HTML files correctly

Added logic to differentiate between plain text and HTML files during the save operation. Ensures proper handling of HTML content when saving.


  Commit: 986c768bbcb14965d51887689565ab5ca2c7566f
      https://github.com/ehb54/ultrascan3/commit/986c768bbcb14965d51887689565ab5ca2c7566f
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_editor.cpp

  Log Message:
  -----------
  Standardize code style and improve readability in US_Editor

Refactored code logic in `file_directory` and `file_extension` setup to improve clarity and consistency.
Standardized brace usage and indentation across functions.
Replaced redundant variable declarations and reorganized control structures for better readability and maintainability.


  Commit: bb376a413c1301fb38bd9a54d7a3671960e1f479
      https://github.com/ehb54/ultrascan3/commit/bb376a413c1301fb38bd9a54d7a3671960e1f479
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_editor.h

  Log Message:
  -----------
  Standardize parameter naming and improve code consistency in `US_Editor`


  Commit: 180c0d2cef2fab282007fc9f1401662d7f8bd736
      https://github.com/ehb54/ultrascan3/commit/180c0d2cef2fab282007fc9f1401662d7f8bd736
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_gui_util.cpp

  Log Message:
  -----------
  Replace `Qt::endl` with `\n` in `us_gui_util.cpp` to prevent flushing of the file on every line


  Commit: 8e787ab3072869783e06bc2baebd217dc5e53080
      https://github.com/ehb54/ultrascan3/commit/8e787ab3072869783e06bc2baebd217dc5e53080
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_gui_util.cpp

  Log Message:
  -----------
  Fix indentation and adjust placement of `myFile.close()` in `us_gui_util.cpp`

only attempt to close the file when it was actually opened


  Commit: 0be568fbb8437939e4f082eb73e23f113a2925cf
      https://github.com/ehb54/ultrascan3/commit/0be568fbb8437939e4f082eb73e23f113a2925cf
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_gui_util.cpp

  Log Message:
  -----------
  Code formating to match the general style


  Commit: 12232e6c496c0a26c105ba0c21435181baa5357b
      https://github.com/ehb54/ultrascan3/commit/12232e6c496c0a26c105ba0c21435181baa5357b
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_plot3d.cpp

  Log Message:
  -----------
  Remove redundant `setVisible(true)` call in `us_plot3d.cpp`

Virtual functions shouldn't be called in the initializer of a class. Further this will make the window always visible, when we might not want it (us_fematch in auto mode for example directly sets the visible back to false). By removing this we prevent any sort of flashing the window


  Commit: c086cb169555b76816cec25e4bfc219869761e3a
      https://github.com/ehb54/ultrascan3/commit/c086cb169555b76816cec25e4bfc219869761e3a
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_plot3d.cpp
    M gui/us_plot3d.h

  Log Message:
  -----------
  Refactor `save_csv` logic in `us_plot3d` for modularity and code reuse

Extracted CSV saving functionality into a standalone `save_csv` method. Simplifies the main logic and improves maintainability by consolidating duplicated code into a single reusable function.


  Commit: 26351a9db3bd146c94dc688ba9c15d427466d241
      https://github.com/ehb54/ultrascan3/commit/26351a9db3bd146c94dc688ba9c15d427466d241
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M gui/us_plot3d.cpp
    M gui/us_plot3d.h

  Log Message:
  -----------
  Code refactoring and cleanup, get rid of some compiler warnings and make clang(-tidy) a bit happier


  Commit: bafec86cfd0b2ca0ce24806eaec89db5b89a1d62
      https://github.com/ehb54/ultrascan3/commit/bafec86cfd0b2ca0ce24806eaec89db5b89a1d62
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_advanced_fem.cpp

  Log Message:
  -----------
  Fix initialization of the advanced dialog from the passed parameter map for all settings of the dialog


  Commit: f48da50cfb5b8d161c1a3440bcf7cf6107247b38
      https://github.com/ehb54/ultrascan3/commit/f48da50cfb5b8d161c1a3440bcf7cf6107247b38
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_fematch.cpp
    M programs/us_fematch/us_fematch.h

  Log Message:
  -----------
  Fix losing track of the report window.

Ensure to keep a pointer to the current report window and properly close it when switching triple. Further update the current existing report window instead of creating a new one every time the view report button is pressed


  Commit: 498eb9ee2319b28eaca538cbdaa5340cfd872cbd
      https://github.com/ehb54/ultrascan3/commit/498eb9ee2319b28eaca538cbdaa5340cfd872cbd
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_fematch.cpp

  Log Message:
  -----------
  Update dialog logic, use the QPointer properly, don't shift the positions constantly and let the OS window manager handle that


  Commit: b2fd73f1c638c8253da63e604ab5d27ef88a65da
      https://github.com/ehb54/ultrascan3/commit/b2fd73f1c638c8253da63e604ab5d27ef88a65da
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_fematch.cpp

  Log Message:
  -----------
  Respect the users wish of the choosen mesh type and don't change it under the hood without any warning. Properly pass the buffer to astfvm


  Commit: 04c253a88eda5e86fe7ead3ed0419a3e3583df9c
      https://github.com/ehb54/ultrascan3/commit/04c253a88eda5e86fe7ead3ed0419a3e3583df9c
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_fematch.cpp

  Log Message:
  -----------
  Pass the choice of the meshtype to the simparams, so changing it actually makes a difference


  Commit: c3977850c76489e50f19cf92397ef6876cefe73d
      https://github.com/ehb54/ultrascan3/commit/c3977850c76489e50f19cf92397ef6876cefe73d
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_fematch.cpp

  Log Message:
  -----------
  Fix inconsistent indentation and adjust braces in `us_fematch.cpp`

Standardize code formatting by correcting indentation and aligning braces properly for better code readability and maintainability.


  Commit: 267d0ed4ee3c6c58f0290fbdafe8aa5022ac2f18
      https://github.com/ehb54/ultrascan3/commit/267d0ed4ee3c6c58f0290fbdafe8aa5022ac2f18
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_fematch.cpp

  Log Message:
  -----------
  Add detailed solution and simulation parameters to the report table in `us_fematch`

Enhance report generation by including additional solution details and simulation parameters, such as correction factors, mesh type, grid type, simulation points, and radial resolution, improving the comprehensiveness of the generated reports.


  Commit: d30bd5ff07ee7f9cfe933a5d6fcbcc8f8185fdc0
      https://github.com/ehb54/ultrascan3/commit/d30bd5ff07ee7f9cfe933a5d6fcbcc8f8185fdc0
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_plot_control_fem.cpp
    M programs/us_fematch/us_plot_control_fem.h

  Log Message:
  -----------
  Ensure proper cleanup of 3D plot window on plot control dialog close

Override `closeEvent` to close the 3D plot window and added a `close_everything` method for robust cleanup, preventing potential dangling pointers and memory issues.


  Commit: 6cf5535819f63dee7dbac22820d15f6ef1669bf2
      https://github.com/ehb54/ultrascan3/commit/6cf5535819f63dee7dbac22820d15f6ef1669bf2
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_plot_control_fem.cpp
    M programs/us_fematch/us_plot_control_fem.h

  Log Message:
  -----------
  Add a little save button to the plot control to save all s-X plots as csv files to disk


  Commit: d0665ab07d3ba1ffc60a4129705a0729949ae68d
      https://github.com/ehb54/ultrascan3/commit/d0665ab07d3ba1ffc60a4129705a0729949ae68d
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_plot_control_fem.cpp

  Log Message:
  -----------
  Use `nullptr` instead of `0` for pointer checks and add `using namespace Qwt3D`.


  Commit: 10a16b13c701a731b227f35bf1d690390f8c6637
      https://github.com/ehb54/ultrascan3/commit/10a16b13c701a731b227f35bf1d690390f8c6637
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_fematch/us_resplot_fem.cpp
    M programs/us_fematch/us_resplot_fem.h

  Log Message:
  -----------
  Add "Save All" button to save plots as CSV files and implement `save_all` functionality

Quickly export data simulation, residuals, TI und RI Noise to disk as csv file


  Commit: 9f93ed03d866cbbdb7d160a030870eb4c86536b6
      https://github.com/ehb54/ultrascan3/commit/9f93ed03d866cbbdb7d160a030870eb4c86536b6
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_pseudo_absorbance/us_add_refScan.cpp

  Log Message:
  -----------
  Replace `Qt::endl` with newline character and ensure proper file handling by flushing and closing the output file


  Commit: c82f9977db524952a5ea042db2660fbee7e09edc
      https://github.com/ehb54/ultrascan3/commit/c82f9977db524952a5ea042db2660fbee7e09edc
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M programs/us_pseudo_absorbance/us_add_refScan.cpp

  Log Message:
  -----------
  Standardize braces around conditional blocks for clarity and consistency in output file formatting loops.


Compare: https://github.com/ehb54/ultrascan3/compare/3ce70f11d71c...c82f9977db52

To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications


More information about the us-commits mailing list