[us-commits] [ehb54/ultrascan3] 1e5517: Ensure speed_step rollback in case of an incom...

ehb54 noreply at github.com
Fri Mar 21 13:56:33 MDT 2025


  Branch: refs/heads/master
  Home:   https://github.com/ehb54/ultrascan3
  Commit: 1e5517c3d4c26112d469437128daaacf24aad708
      https://github.com/ehb54/ultrascan3/commit/1e5517c3d4c26112d469437128daaacf24aad708
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M utils/us_simparms.cpp

  Log Message:
  -----------
      Ensure speed_step rollback in case of an incomplete sp_*.xml file

    Added logic to revert speed_step to its previous state if the simulation parameters are found to have empty speed steps. This guarantees consistency and prevents invalid simulation states during processing.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: 05883c2e6030793142fc626a132d3b7390307787
      https://github.com/ehb54/ultrascan3/commit/05883c2e6030793142fc626a132d3b7390307787
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M test/utils/CMakeLists.txt
    A test/utils/test_us_simparams.cpp
    A test/utils/test_us_simparams.h
    M test/utils/test_us_utils_main.cpp

  Log Message:
  -----------
  Add unit tests for US_SimulationParameters functionality

This commit introduces comprehensive unit tests for the US_SimulationParameters class, covering various cases for XML parsing, file handling, and data validation. Tests ensure reliability in saving/loading simulation parameters and handling edge scenarios.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: feeac9e23878ebf748ddec14f1b59d9809fb8135
      https://github.com/ehb54/ultrascan3/commit/feeac9e23878ebf748ddec14f1b59d9809fb8135
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M test/utils/test_us_simparams.h

  Log Message:
  -----------
  Update include directive to correct header file name

Renamed the included file from "us_simparams.h" to "us_simparms.h" to fix a typo in the file name. This change ensures proper file referencing and resolves any potential compilation issues.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: 9c0d51ceb1d8c0da9b557ab665b66be31e601d90
      https://github.com/ehb54/ultrascan3/commit/9c0d51ceb1d8c0da9b557ab665b66be31e601d90
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M utils/CMakeLists.txt

  Log Message:
  -----------
  Add us_simparms files to utils library in CMakeLists.txt

Included `us_simparms.cpp` and `us_simparms.h` in the utils library definition. This ensures these files are compiled and linked correctly as part of the utils library.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: dc37f6d9f6ead541356d5f5339df6ab132fce492
      https://github.com/ehb54/ultrascan3/commit/dc37f6d9f6ead541356d5f5339df6ab132fce492
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M test/utils/CMakeLists.txt

  Log Message:
  -----------
  Update Qt5 components in test utils CMakeLists.txt

Added Network and Sql components to the Qt5 find_package call. This ensures the necessary Qt5 modules are available for tests that depend on these additional components.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: 809f74141edefadff8f75632172b781908c1efc0
      https://github.com/ehb54/ultrascan3/commit/809f74141edefadff8f75632172b781908c1efc0
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M utils/CMakeLists.txt

  Log Message:
  -----------
  Add MySQL include directories and link libraries to utils

This update integrates MySQL headers and libraries by including their paths in the CMake configuration. It ensures proper compilation and linkage for utils with MySQL dependencies.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: 4e33a7c67fdb2939f309be162b4e8827c263e14f
      https://github.com/ehb54/ultrascan3/commit/4e33a7c67fdb2939f309be162b4e8827c263e14f
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M utils/CMakeLists.txt

  Log Message:
  -----------
      Remove redundant PUBLIC specifier from target_link_libraries

    The PUBLIC specifier was unnecessary and has been removed to simplify the code. This change has no functional impact but improves clarity and consistency in the CMake configuration.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: 58b733d2ce1a18aee5d6f8e663179c5e10061d0c
      https://github.com/ehb54/ultrascan3/commit/58b733d2ce1a18aee5d6f8e663179c5e10061d0c
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M CMakeLists.txt
    M utils/CMakeLists.txt

  Log Message:
  -----------
  Remove MySQL dependencies and define NO_DB for builds

This commit eliminates hardcoded MySQL include directories and libraries from the utils module, simplifying the build process. Additionally, the NO_DB definition is added to indicate database-related functionalities are disabled. This paves the way for building projects without MySQL support.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: 748cc00f2377140ce224a22a77beccdd19f548b9
      https://github.com/ehb54/ultrascan3/commit/748cc00f2377140ce224a22a77beccdd19f548b9
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M test/utils/test_us_simparams.cpp

  Log Message:
  -----------
  Fix namespace ambiguity for SpeedProfile in test file

Updated the `SpeedProfile` declaration to use the fully qualified `US_SimulationParameters::SpeedProfile` to resolve potential namespace ambiguity. This ensures clarity and correctness in the test code.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: d01b9c7d9856ebc0e4967b7bd2703f7ffbf968a8
      https://github.com/ehb54/ultrascan3/commit/d01b9c7d9856ebc0e4967b7bd2703f7ffbf968a8
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M utils/CMakeLists.txt

  Log Message:
  -----------
  Update utils library with additional source files and dependencies

Added numerous source and header files to the utils library and linked additional Qt modules (Sql, Network, Xml) and the archive library. Updated include directories to include `/usr/include` and `/usr/include/mysql`. These changes enhance the functionality and compatibility of the utils module.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: 07798394ab1b8aa587ed9624fc1b1600a7d06664
      https://github.com/ehb54/ultrascan3/commit/07798394ab1b8aa587ed9624fc1b1600a7d06664
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M test/utils/test_us_simparams.cpp

  Log Message:
  -----------
  Refactor XML writing and fix test issues

Replaced manual XML string creation with `QXmlStreamWriter` for better readability and maintainability. Fixed typos and improved test assertions to address debug and edge-case issues. Adjusted `speed_step` handling to align with expected behavior in tests.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: 0426ae346d05b4905a4e0c5239e779df5fbb3c39
      https://github.com/ehb54/ultrascan3/commit/0426ae346d05b4905a4e0c5239e779df5fbb3c39
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M test/utils/test_us_simparams.cpp

  Log Message:
  -----------
  Remove debug call from test_us_simparams.

The debug function call was unnecessary and has been removed to clean up the test code. This improves code clarity and reduces noise in the output during test execution.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: d3a9e0d4099f65b91ef36137e1c208eb428b91a2
      https://github.com/ehb54/ultrascan3/commit/d3a9e0d4099f65b91ef36137e1c208eb428b91a2
  Author: doluk <69309597+doluk at users.noreply.github.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M .github/workflows/codeql-analysis.yml

  Log Message:
  -----------
  Add libarchive-dev to CodeQL build dependencies

The addition of libarchive-dev ensures all necessary libraries are installed for builds during CodeQL analysis. This prevents potential build failures or missing dependencies.

Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>


  Commit: a5b95158ed1ac65a8123e49d81501eafbcce37bf
      https://github.com/ehb54/ultrascan3/commit/a5b95158ed1ac65a8123e49d81501eafbcce37bf
  Author: ehb54 <ehb54 at users.noreply.github.com>
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
    M .github/workflows/codeql-analysis.yml
    M CMakeLists.txt
    M test/utils/CMakeLists.txt
    A test/utils/test_us_simparams.cpp
    A test/utils/test_us_simparams.h
    M test/utils/test_us_utils_main.cpp
    M utils/CMakeLists.txt
    M utils/us_simparms.cpp

  Log Message:
  -----------
  Merge pull request #189 from ehb54/lukas/us_astfem_sim_empty_simparams

Prevent missing speed steps in simulation parameters file from crashing applications


Compare: https://github.com/ehb54/ultrascan3/compare/5946d5a0f95b...a5b95158ed1a

To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications


More information about the us-commits mailing list