[us-commits] [ehb54/ultrascan3] 339cdf: Add CLI support and refactor US Astfem Sim module
Borries Demeler
noreply at github.com
Fri Mar 21 14:35:50 MDT 2025
Branch: refs/heads/master
Home: https://github.com/ehb54/ultrascan3
Commit: 339cdfb9969efcc849a4bad7b24a1a9d19f4deac
https://github.com/ehb54/ultrascan3/commit/339cdfb9969efcc849a4bad7b24a1a9d19f4deac
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-01-22 (Wed, 22 Jan 2025)
Changed paths:
M gui/us_buffer_gui.cpp
M gui/us_buffer_gui.h
M gui/us_model_gui.cpp
M gui/us_model_gui.h
M gui/us_rotor_gui.cpp
M gui/us_rotor_gui.h
M gui/us_sim_params_gui.cpp
M gui/us_sim_params_gui.h
M programs/us_astfem_sim/us_astfem_sim.cpp
M programs/us_astfem_sim/us_astfem_sim.h
M programs/us_astfem_sim/us_clipdata.h
Log Message:
-----------
Add CLI support and refactor US Astfem Sim module
Implemented comprehensive command-line interface (CLI) parsing to enable headless operation, including flags for model, buffer, simulation parameters, rotor, and output options. Refactored variable names, added initialization for key attributes, and made codebase improvements like replacing raw pointers and enhancing readability. Introduced optional GUI-less behavior for improved automation and streamlined workflow.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 4dfcb52b7d4544e654ab73f30cafde902136c303
https://github.com/ehb54/ultrascan3/commit/4dfcb52b7d4544e654ab73f30cafde902136c303
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-01-22 (Wed, 22 Jan 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
Log Message:
-----------
Fix: us_astfem_sim producing wrong timestates
Corrected the formula for omega2t sum to use the average speed during acceleration instead of the final speed for each step. This fixes https://github.com/ehb54/ultrascan-tickets/issues/406
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 6fda53236b145fc4bb45c3d2131b23104c40d7f2
https://github.com/ehb54/ultrascan3/commit/6fda53236b145fc4bb45c3d2131b23104c40d7f2
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-01-22 (Wed, 22 Jan 2025)
Changed paths:
M gui/us_rotor_gui.cpp
Log Message:
-----------
Fix: remove debugging output
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 72a05eecd155a98e0a5a521b98cb02ce1de0e831
https://github.com/ehb54/ultrascan3/commit/72a05eecd155a98e0a5a521b98cb02ce1de0e831
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-02-05 (Wed, 05 Feb 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
Log Message:
-----------
Fix: Revert initialization of meniscus_ar to prevent edge case
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 6389170887f6efcd5c9a24c6fe8e30790787f4f2
https://github.com/ehb54/ultrascan3/commit/6389170887f6efcd5c9a24c6fe8e30790787f4f2
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-02-20 (Thu, 20 Feb 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
Log Message:
-----------
Add CLI option to handle errors and bypass GUI if specified
Introduced a new command-line option, `errors-cl`, to redirect error messages to the console and prevent GUI initialization when errors occur. Enhanced error handling across various loading processes (model, buffer, simulation parameters, rotor, and save path) to respect this option and exit gracefully in headless mode. This update improves usability in non-GUI environments.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: ffd75b0e5ff1534c899959c9ad6d56d1d94e595f
https://github.com/ehb54/ultrascan3/commit/ffd75b0e5ff1534c899959c9ad6d56d1d94e595f
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-02-20 (Thu, 20 Feb 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
Log Message:
-----------
Fix bracket errors
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: ccc9e240b6e49a3788cda94636f78934f3dcea8c
https://github.com/ehb54/ultrascan3/commit/ccc9e240b6e49a3788cda94636f78934f3dcea8c
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-07 (Fri, 07 Mar 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
Log Message:
-----------
Initialize meniscus_ar properly
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: f10f53437efb9c3fde45fae8c86bb073b2f97524
https://github.com/ehb54/ultrascan3/commit/f10f53437efb9c3fde45fae8c86bb073b2f97524
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-13 (Thu, 13 Mar 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
Log Message:
-----------
Set simulation parameter flag in set_parameters()
Added the `simparams.sim` flag initialization to ensure proper simulation configuration. This change aligns with the expected setup behavior during parameter initialization.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: a78a16abccfc8dab04340497917c4a3d8b3336a2
https://github.com/ehb54/ultrascan3/commit/a78a16abccfc8dab04340497917c4a3d8b3336a2
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-13 (Thu, 13 Mar 2025)
Changed paths:
M programs/us_convert/us_convert.cpp
Log Message:
-----------
Adjust acceleration correction calculations in us_convert.cpp
Updated the tfac multiplier to (3.0 / 2.0) and revised formulas for azwrate and w_offs to ensure more accurate handling of low acceleration scenarios. These changes align better with the intended mathematical model and improve calculation precision.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 612793407746781c19aa30c284bd884030f618d7
https://github.com/ehb54/ultrascan3/commit/612793407746781c19aa30c284bd884030f618d7
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-13 (Thu, 13 Mar 2025)
Changed paths:
M utils/us_astfem_math.cpp
Log Message:
-----------
Adjust acceleration factor calculation in ASTFEM math.
Updated the `tfac` factor from `4/3` to `3/2` to correct the acceleration time calculation. This aligns the code with the refined mathematical model and ensures more accurate computations of rotor dynamics.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: bc198e7562788b8197fc562cffdf32a0387054a3
https://github.com/ehb54/ultrascan3/commit/bc198e7562788b8197fc562cffdf32a0387054a3
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-13 (Thu, 13 Mar 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
Log Message:
-----------
Add additional debug logs for simulation parameter tracking
Enhanced debug output by including more details about key variables such as `w2tinc`, `timeinc`, and `time1` during the parameter setup. These changes aim to facilitate debugging and provide clearer insights into simulation computations.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 1203a9f845938da8b1dd4281e0dd072a1a37ad61
https://github.com/ehb54/ultrascan3/commit/1203a9f845938da8b1dd4281e0dd072a1a37ad61
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-17 (Mon, 17 Mar 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
M programs/us_astfem_sim/us_astfem_sim.h
Log Message:
-----------
Automatically save run.xml and edit.xml when saving simulation data
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 6cc9d10408d91922519bc36e4aa578d61facdf51
https://github.com/ehb54/ultrascan3/commit/6cc9d10408d91922519bc36e4aa578d61facdf51
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-17 (Mon, 17 Mar 2025)
Changed paths:
M programs/us_convert/us_convert.cpp
Log Message:
-----------
fix the w_offs calculation based on the new formular
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: d9da67e53742197104782eeca25be6de2e54449c
https://github.com/ehb54/ultrascan3/commit/d9da67e53742197104782eeca25be6de2e54449c
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-17 (Mon, 17 Mar 2025)
Changed paths:
M programs/us_astfem_sim/us_astfem_sim.cpp
Log Message:
-----------
Update omega2t calculation logic and fix type casting.
Revised the computation of `w2tsum` to improve accuracy during acceleration and constant-speed phases. Added a type cast to ensure `time_first` is stored as an integer. These changes enhance precision and prevent potential runtime issues.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: b6a6d1a88ca4a976b611cb81541ea788d2670d97
https://github.com/ehb54/ultrascan3/commit/b6a6d1a88ca4a976b611cb81541ea788d2670d97
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-17 (Mon, 17 Mar 2025)
Changed paths:
M utils/us_astfem_math.cpp
Log Message:
-----------
Use `qCeil` instead of `qRound` for calculating `t_acc`.
This change ensures more accurate calculation of `t_acc` by rounding up instead of rounding to the nearest value. Additionally, the `rate` is now explicitly set to the acceleration value for improved clarity and consistency.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: cc895612beb7bb224a4d8d1bc03c0d19e76bc213
https://github.com/ehb54/ultrascan3/commit/cc895612beb7bb224a4d8d1bc03c0d19e76bc213
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-17 (Mon, 17 Mar 2025)
Changed paths:
M utils/us_astfem_math.cpp
Log Message:
-----------
Lower debug log level in us_astfem_math.cpp
Changed DbgLv from 1 to 0 for multiple debug statements to reduce verbosity in logs. This adjustment ensures logs are less cluttered while maintaining relevant debug information at a lower level.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: fd700352a45226b0da7a733e268a08635fc6070f
https://github.com/ehb54/ultrascan3/commit/fd700352a45226b0da7a733e268a08635fc6070f
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-21 (Fri, 21 Mar 2025)
Changed paths:
M programs/us_2dsa/us_2dsa.cpp
M programs/us_autoflow_analysis/us_autoflow_analysis.cpp
M programs/us_convert/us_convert_gui.cpp
M programs/us_experiment/us_experiment_gui_optima.cpp
M programs/us_fematch/us_fematch.cpp
M programs/us_mpi_analysis/us_mpi_analysis.cpp
M programs/us_reporter_gmp/us_reporter_gmp.cpp
Log Message:
-----------
Allow less delay between acceleration end and first scan
The previous calculation relied on an overestimated acceleration rate in the speed step resulting in an offset of -3 for the scan timing based on experimental observations. The updated calculation for the timestate makes this correction obsolete. In order to keep not suddenly display errors for older data, the offset of +1 is applied due to making tf_aend a double instead of an integer avoiding potential rounding issues.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 71ae863185de5258ef5278c458039cd111bbeeb9
https://github.com/ehb54/ultrascan3/commit/71ae863185de5258ef5278c458039cd111bbeeb9
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-21 (Fri, 21 Mar 2025)
Changed paths:
A doc/calc_timestate_documentation.pdf
Log Message:
-----------
Add calc_timestate_documentation.pdf
Include documentation detailing the calculation of timestate functionality.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 3d26140d83e2dd3feb2ffd3c2c3ab97d002c0580
https://github.com/ehb54/ultrascan3/commit/3d26140d83e2dd3feb2ffd3c2c3ab97d002c0580
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-21 (Fri, 21 Mar 2025)
Changed paths:
M programs/us_convert/us_convert.cpp
Log Message:
-----------
Update time offset calculation comment with documentation reference
Added a reference to detailed documentation for the time and omega^2t offset calculation process. This improves code clarity and provides additional context for future developers.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 25a0b68c911eb5456f91e2e26160ca80a7dd1822
https://github.com/ehb54/ultrascan3/commit/25a0b68c911eb5456f91e2e26160ca80a7dd1822
Author: doluk <69309597+doluk at users.noreply.github.com>
Date: 2025-03-21 (Fri, 21 Mar 2025)
Changed paths:
A doc/calc_model_coefficient_documentation.pdf
R utils/calc_coefficient_documentation.pdf
M utils/us_model.cpp
Log Message:
-----------
Update coefficient documentation reference and relocate file
Updated comments to reference the new path for the coefficient documentation file. Relocated the file from `utils` to the `doc` directory for better organization.
Signed-off-by: doluk <69309597+doluk at users.noreply.github.com>
Commit: 1f81945e1f1214104abbb6b6f01441085ad6de3a
https://github.com/ehb54/ultrascan3/commit/1f81945e1f1214104abbb6b6f01441085ad6de3a
Author: Borries Demeler <7659499+demeler at users.noreply.github.com>
Date: 2025-03-21 (Fri, 21 Mar 2025)
Changed paths:
A doc/calc_model_coefficient_documentation.pdf
A doc/calc_timestate_documentation.pdf
M gui/us_buffer_gui.cpp
M gui/us_buffer_gui.h
M gui/us_model_gui.cpp
M gui/us_model_gui.h
M gui/us_rotor_gui.cpp
M gui/us_rotor_gui.h
M gui/us_sim_params_gui.cpp
M gui/us_sim_params_gui.h
M programs/us_2dsa/us_2dsa.cpp
M programs/us_astfem_sim/us_astfem_sim.cpp
M programs/us_astfem_sim/us_astfem_sim.h
M programs/us_astfem_sim/us_clipdata.h
M programs/us_autoflow_analysis/us_autoflow_analysis.cpp
M programs/us_convert/us_convert.cpp
M programs/us_convert/us_convert_gui.cpp
M programs/us_experiment/us_experiment_gui_optima.cpp
M programs/us_fematch/us_fematch.cpp
M programs/us_mpi_analysis/us_mpi_analysis.cpp
M programs/us_reporter_gmp/us_reporter_gmp.cpp
R utils/calc_coefficient_documentation.pdf
M utils/us_astfem_math.cpp
M utils/us_model.cpp
Log Message:
-----------
Merge pull request #175 from ehb54/lukas/us_astfem_sim_timestate
US Simulation Module Fix/Enhancement
Compare: https://github.com/ehb54/ultrascan3/compare/a5b95158ed1a...1f81945e1f12
To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
More information about the us-commits
mailing list