[us-commits] [ehb54/us3lims_common] ea843d: CSP: remove last inline script, add window-close h...
emre brookes
noreply at github.com
Fri Aug 7 12:05:50 MDT 2026
Branch: refs/heads/ehb54-issue-478-rebase
Home: https://github.com/ehb54/us3lims_common
Commit: ea843de80aa1ce0e6795d27d26b43b60decd28a1
https://github.com/ehb54/us3lims_common/commit/ea843de80aa1ce0e6795d27d26b43b60decd28a1
Author: ehb54 <brookes at uthscsa.edu>
Date: 2026-08-07 (Fri, 07 Aug 2026)
Changed paths:
M class/progress.php
M css/common.css
M js/main.js
Log Message:
-----------
CSP: remove last inline script, add window-close handler, font-bold utility
- class/progress.php emitted an inline <script> defining us_submit_prog.
Moved that definition into js/main.js, which is already loaded on every
page, and made the element lookup lazy since main.js loads from <head>
while progress.php is included part-way down the body. Initial hidden
state now comes from the d-none class instead of a hide() call at parse
time. The div also still carried a pre-rename generated class name that
no stylesheet defines; corrected to font-mono-center-20px.
Note: the 478 work removed every caller of us_submit_prog, since it
worked by streaming <script> blocks mid-response, which CSP cannot
allow. The object is kept for API compatibility but is now unused --
worth deciding separately whether to drop it.
- main.js: onclick-window-close branch, replacing href='javascript:...'
close links in us3lims_dbinst report_detail.php / solution_detail.php.
- common.css: .font-bold utility, so the red bold submission-error spans
in us3lims_dbinst can drop their inline style.
To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/us3lims_common/settings/notifications
More information about the us-commits
mailing list