[us-commits] [ehb54/ultrascan3] 6fbfe7: perceiver: stop the review dialog overriding the e...

[emre brookes]

  Branch: refs/heads/ehb54-issue-980
  Home:   https://github.com/ehb54/ultrascan3
  Commit: 6fbfe7a46324b90c0114ac43afa49c5058070307
      https://github.com/ehb54/ultrascan3/commit/6fbfe7a46324b90c0114ac43afa49c5058070307
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-08-09 (Sun, 09 Aug 2026)

  Changed paths:
    M us_somo/develop/include/us_hydrodyn_perceive_dialog.h
    M us_somo/develop/perceiver/tests/dialog_qt.cpp
    M us_somo/develop/src/us_hydrodyn_perceive_dialog.cpp

  Log Message:
  -----------
  perceiver: stop the review dialog overriding the emitted ASA

The dialog does not write the perceiver's block -- refresh_entry() rebuilds
the whole entry from its widgets, and its header format string hardcoded the
ASA slot to 0:

    s += QString( "%1\t0\t%2\t0\t%3\t1\t%4\n" )

so fixing the emitter changed nothing for anyone using the GUI. A run shows
both the new REVIEW line about the ASA placeholder AND a header reading
"SO4 0 61.75 0 5 1 0.390" -- one binary, two emitters, and the loaders drop a
zero-ASA record silently, so the residue stayed non-coded after acceptance.

"perceive apply" could not catch this: it uses the Tentative block directly
and never constructs a dialog, so it exercised the half that was already
right. The dialog now parses type and ASA out of the proposed header and
writes them back untouched, editing only what it owns -- molvol, vbar,
hydration and colour. Anything it hardcodes silently overrides perception,
so it should hold nothing it does not edit.

The dialog test could not catch it either: its fixture block carried ASA 0,
so any assertion would have passed vacuously. The fixture now carries 54.00
and the test parses the rebuilt header and asserts the ASA field is positive
and still 54.0, alongside molvol -- the two fields the loaders gate on.

25 checks, 0 failures; Qt-free suites unchanged (54/35/18/60/37/55).



To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications