[us-commits] [ehb54/ultrascan3] f6627f: somo: close RasMol viewers a gui_script opened, ra...

[emre brookes]

  Branch: refs/heads/ehb54-issue-1000
  Home:   https://github.com/ehb54/ultrascan3
  Commit: f6627f7cd8c199bd5ffafc5c584bc570f9969003
      https://github.com/ehb54/ultrascan3/commit/f6627f7cd8c199bd5ffafc5c584bc570f9969003
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M us_somo/develop/include/us_hydrodyn.h
    M us_somo/develop/src/us_hydrodyn.cpp
    M us_somo/develop/src/us_hydrodyn_script.cpp

  Log Message:
  -----------
  somo: close RasMol viewers a gui_script opened, rather than orphaning them

A gui_script never reaches closeEvent() - "exit" calls exit(0) directly, and
gui_script_error() calls exit(-1) - so the exit prompt was not a hang risk
(guiFlag is false for the duration of a script in any case).  But it also meant
nothing cleaned up: auto_view_pdb is on by default, so any script that loads a
PDB without saying "norasmol" left a RasMol process behind on every run.

Route all three script exits through gui_script_exit(), which closes the
tracked viewers and says so on stdout.  A script that wants them kept says

   rasmol leaveopen

and "rasmol close" spells out the default.  A script that runs off the end
without "exit" hands back to the GUI, where the interactive prompt still
applies - the viewers belong to whoever is now at the keyboard.



To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications