[us-commits] [ehb54/ultrascan3] c32962: Fix theme edge cases

[alexsav815]

  Branch: refs/heads/alexey-dev-issue1020
  Home:   https://github.com/ehb54/ultrascan3
  Commit: c32962f2eaf66f7230830f436e0fdb491e8ad9a8
      https://github.com/ehb54/ultrascan3/commit/c32962f2eaf66f7230830f436e0fdb491e8ad9a8
  Author: Lukas Dobler <69309597+doluk at users.noreply.github.com>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M gui/us_plot.cpp
    M gui/us_plot.h
    M gui/us_solution_gui.cpp
    M gui/us_theme.cpp
    M gui/us_theme.h
    M gui/us_widgets.cpp
    M gui/us_widgets_dialog.cpp
    M programs/us_config/us_color.cpp

  Log Message:
  -----------
  Fix theme edge cases


  Commit: 541ee619eefc3ce6c914f427300b34e325e1b9bb
      https://github.com/ehb54/ultrascan3/commit/541ee619eefc3ce6c914f427300b34e325e1b9bb
  Author: Lukas Dobler <69309597+doluk at users.noreply.github.com>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M us_somo/develop/include/us_hydrodyn_perceive_dialog.h

  Log Message:
  -----------
  Merge branch 'main' into lukas/theme-fixes


  Commit: ebd251ac84ba1fdb734b8d72ac3bac37e6d6c433
      https://github.com/ehb54/ultrascan3/commit/ebd251ac84ba1fdb734b8d72ac3bac37e6d6c433
  Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M VERSION
    M utils/us_defines.h

  Log Message:
  -----------
  Bump version to 4.2.0


  Commit: c3af75e5474aa48d83525e0131866f61357ca870
      https://github.com/ehb54/ultrascan3/commit/c3af75e5474aa48d83525e0131866f61357ca870
  Author: aaron-auc <95181880+aaron-auc at users.noreply.github.com>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M doc/manual/source/conf.py

  Log Message:
  -----------
  Update docs version to v4.2.0 in conf.py


  Commit: b6fe806f04bd4ffa22a2ea0d3a338b5a2ca208e0
      https://github.com/ehb54/ultrascan3/commit/b6fe806f04bd4ffa22a2ea0d3a338b5a2ca208e0
  Author: Lukas Dobler <69309597+doluk at users.noreply.github.com>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M gui/us_plot.cpp
    M gui/us_plot.h
    M gui/us_solution_gui.cpp
    M gui/us_theme.cpp
    M gui/us_theme.h
    M gui/us_widgets.cpp
    M gui/us_widgets_dialog.cpp
    M programs/us_config/us_color.cpp

  Log Message:
  -----------
  Merge pull request #528 from ehb54/lukas/theme-fixes

Fix theme edge cases


  Commit: 03df6a27c1dcfd2740fa58f3bc38da61ec94f407
      https://github.com/ehb54/ultrascan3/commit/03df6a27c1dcfd2740fa58f3bc38da61ec94f407
  Author: aaron-auc <95181880+aaron-auc at users.noreply.github.com>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M gui/us_plot.cpp
    M gui/us_plot.h
    M gui/us_solution_gui.cpp
    M gui/us_theme.cpp
    M gui/us_theme.h
    M gui/us_widgets.cpp
    M gui/us_widgets_dialog.cpp
    M programs/us_config/us_color.cpp

  Log Message:
  -----------
  Merge branch 'main' into bump-to-v4.2.0


  Commit: 9887a93993076263fc434ca7610e1fe94096aec5
      https://github.com/ehb54/ultrascan3/commit/9887a93993076263fc434ca7610e1fe94096aec5
  Author: emre brookes <ehb54 at users.noreply.github.com>
  Date:   2026-08-19 (Wed, 19 Aug 2026)

  Changed paths:
    M VERSION
    M doc/manual/source/conf.py
    M utils/us_defines.h

  Log Message:
  -----------
  Merge pull request #531 from ehb54/bump-to-v4.2.0

Bump to v4.2.0


  Commit: d6c7fbd12aab697c443183f00b8f48d4af54aae8
      https://github.com/ehb54/ultrascan3/commit/d6c7fbd12aab697c443183f00b8f48d4af54aae8
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M gui.pri

  Log Message:
  -----------
  Define US_MAKE_DLL and QWT_DLL for Windows application builds

Applications include gui.pri, which never defined US_MAKE_DLL, so
us_extern.h fell through its Windows branch and expanded US_GUI_EXTERN
and US_UTIL_EXTERN to a GCC visibility attribute instead of
__declspec(dllimport).  qwt_global.h leaves QWT_EXPORT empty on the same
terms, and only libus_gui.pro defined QWT_DLL.

Without the import attribute MinGW resolves the library classes through
import thunks linked into the executable, so taking the address of a
signal in an application translation unit yields the thunk rather than
the function the library holds.  The pointer-to-member form of connect()
matches signals by that address, so every such connection silently
failed to bind on Windows while the string based SIGNAL/SLOT form, which
matches by name, was unaffected.

This surfaced as the meniscus control-click and the scan exclusion click
doing nothing in us_edit on the Windows package.  The CMake build
already defines both for every application target, which is why builds
made through the presets were never affected.


  Commit: 9e358c8bba18a8ccba5b44c40ed4d869c8e69c27
      https://github.com/ehb54/ultrascan3/commit/9e358c8bba18a8ccba5b44c40ed4d869c8e69c27
  Author: emre brookes <ehb54 at users.noreply.github.com>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M gui.pri

  Log Message:
  -----------
  Merge pull request #533 from ehb54/ehb54-qmake-win-dllimport

Fix Windows application builds losing dllimport for us_gui, us_utils and qwt


  Commit: f73ffab665d1015d137908badc7e64212136eebd
      https://github.com/ehb54/ultrascan3/commit/f73ffab665d1015d137908badc7e64212136eebd
  Author: alexsav815 <alexsav.science at gmail.com>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M VERSION
    M doc/manual/source/conf.py
    M gui.pri
    M gui/us_plot.cpp
    M gui/us_plot.h
    M gui/us_solution_gui.cpp
    M gui/us_theme.cpp
    M gui/us_theme.h
    M gui/us_widgets.cpp
    M gui/us_widgets_dialog.cpp
    M programs/us_config/us_color.cpp
    M utils/us_defines.h

  Log Message:
  -----------
  Merge branch 'main' into alexey-dev-issue1020


Compare: https://github.com/ehb54/ultrascan3/compare/c6a60ed2b23d...f73ffab665d1

To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications