[us-commits] [ehb54/ultrascan3] f087cb: Fix SIGSEGV in HPLC SAXS get_peak: use file, not w...
emre brookes
noreply at github.com
Fri Jul 10 10:16:38 MDT 2026
Branch: refs/heads/somo-dev
Home: https://github.com/ehb54/ultrascan3
Commit: f087cb2f504871f6f79df846004b7ea6f0926d57
https://github.com/ehb54/ultrascan3/commit/f087cb2f504871f6f79df846004b7ea6f0926d57
Author: ehb54 <brookes at uthscsa.edu>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M us_somo/develop/src/us_hydrodyn_saxs_hplc.cpp
Log Message:
-----------
Fix SIGSEGV in HPLC SAXS get_peak: use file, not wheel_file, for end-range clamp
get_peak() operates on its `file` argument, but the gauss-fit-end range
clamp compared the typed value against f_qs[ wheel_file ].back() instead
of f_qs[ file ].back(). During Repeak, wheel_file is stale or empty (it is
never set in repeak()), so f_qs[ wheel_file ] default-inserts an empty
vector and .back() dereferences nullptr-8 (0xfffffffffffffff8), crashing.
The check is now symmetric with the start-range clamp above and with its
own body on the next line, both of which key on `file`.
Co-Authored-By: Claude Fable 5 <noreply at anthropic.com>
To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications
More information about the us-commits
mailing list