[us-commits] [ehb54/ultrascan3] 3c4a6a: Fix CodeQL build-target detection: == is not valid...

[emre brookes]

  Branch: refs/heads/main
  Home:   https://github.com/ehb54/ultrascan3
  Commit: 3c4a6a12de6f56ab3ccb0e05512fe01538445686
      https://github.com/ehb54/ultrascan3/commit/3c4a6a12de6f56ab3ccb0e05512fe01538445686
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-06-19 (Fri, 19 Jun 2026)

  Changed paths:
    M .github/workflows/codeql-analysis.yml

  Log Message:
  -----------
  Fix CodeQL build-target detection: == is not valid in POSIX sh [ ]

The "Calculate Build Targets" step runs under sh (dash), where [ ] only
supports = not ==. Every [ "$X" == "true" ] test errored as "unexpected
operator" and was treated as false, so the full-rebuild branch never ran
even on a push to main with FORCE_ALL=true. This meant CodeQL's analysis
database only ever contained whichever programs happened to be touched
by a given push's diff, causing already-open alerts in untouched files
(e.g. us_spectrum.cpp) to flap between Fixed/Reappeared across unrelated
PRs without the underlying code ever changing.

Fixes ehb54/ultrascan-tickets#911


  Commit: 951770eef3cf63893454a5402ccb79e4a64062db
      https://github.com/ehb54/ultrascan3/commit/951770eef3cf63893454a5402ccb79e4a64062db
  Author: emre brookes <ehb54 at users.noreply.github.com>
  Date:   2026-06-19 (Fri, 19 Jun 2026)

  Changed paths:
    A VERSION
    M utils/us_defines.h

  Log Message:
  -----------
  Merge branch 'main' into ehb54-issue-911


  Commit: d981490e29291aa7d6124604cc0ea33dcc753df3
      https://github.com/ehb54/ultrascan3/commit/d981490e29291aa7d6124604cc0ea33dcc753df3
  Author: emre brookes <ehb54 at users.noreply.github.com>
  Date:   2026-06-19 (Fri, 19 Jun 2026)

  Changed paths:
    M .github/workflows/codeql-analysis.yml

  Log Message:
  -----------
  Merge pull request #452 from ehb54/ehb54-issue-911

Fix CodeQL build-target detection (sh != bash, == in [ ])


Compare: https://github.com/ehb54/ultrascan3/compare/733d3f549696...d981490e2929

To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications