[us-commits] [ehb54/us3lims_common] ed4504: Reduce submit_job() cognitive complexity, fix meth...

[emre brookes]

  Branch: refs/heads/ehb54-issue-915
  Home:   https://github.com/ehb54/us3lims_common
  Commit: ed4504fe59fb16de017293bf2a1168bcc884dee1
      https://github.com/ehb54/us3lims_common/commit/ed4504fe59fb16de017293bf2a1168bcc884dee1
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-06-20 (Sat, 20 Jun 2026)

  Changed paths:
    M class/submit_local.php

  Log Message:
  -----------
  Reduce submit_job() cognitive complexity, fix method naming

Extract the sbatch/qsub retry loop and result-parsing logic out of
submit_job() into two small private helpers (attemptSubmit(),
parseSubmitResult()), addressing SonarCloud's flagged Cognitive
Complexity (29 vs 15 allowed). No behavior change, just relocated
code.

Also rename mark_autoflow_submit_failed() to markAutoflowSubmitFailed()
to satisfy the PHP method naming convention rule (php:S100).



To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/us3lims_common/settings/notifications