[us-commits] [ehb54/us3lims_gridctl] 2843ec: Fix race condition causing intermittent "Failed da...

[emre brookes]

  Branch: refs/heads/main
  Home:   https://github.com/ehb54/us3lims_gridctl
  Commit: 2843ec5521e3abaca87929751db9d635958a789e
      https://github.com/ehb54/us3lims_gridctl/commit/2843ec5521e3abaca87929751db9d635958a789e
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-06-20 (Sat, 20 Jun 2026)

  Changed paths:
    M cleanup.php
    M jobmonitor/cleanup.php

  Log Message:
  -----------
  Fix race condition causing intermittent "Failed data fetch"

The analysis-results.tar scp had no retry, and the only wait/backoff
loop polled for stderr's arrival, not the tar itself. If the remote
job finished writing stderr before closing the tar, the tar fetch
silently failed and was never retried, leaving gfac.analysis.tarfile
empty even though the job succeeded.

Add a retry to the tar scp matching stdout/stderr, and a dedicated
backoff loop that re-checks for and re-fetches the tar before giving
up. Applied identically to cleanup.php and jobmonitor/cleanup.php.

Fixes ehb54/ultrascan-tickets#914


  Commit: 299622e1aa03a28eb4bc2874245e56e64cce1aa5
      https://github.com/ehb54/us3lims_gridctl/commit/299622e1aa03a28eb4bc2874245e56e64cce1aa5
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-06-20 (Sat, 20 Jun 2026)

  Changed paths:
    M cleanup.php
    M jobmonitor/cleanup.php

  Log Message:
  -----------
  Add curly braces around single-statement if blocks (SonarCloud)


  Commit: 31337ffaf7aec158264331b22425837f3697d050
      https://github.com/ehb54/us3lims_gridctl/commit/31337ffaf7aec158264331b22425837f3697d050
  Author: emre brookes <ehb54 at users.noreply.github.com>
  Date:   2026-06-20 (Sat, 20 Jun 2026)

  Changed paths:
    M cleanup.php
    M jobmonitor/cleanup.php

  Log Message:
  -----------
  Merge pull request #26 from ehb54/ehb54-issue-914

Fix race condition causing intermittent "Failed data fetch"


Compare: https://github.com/ehb54/us3lims_gridctl/compare/c96169aa306b...31337ffaf7ae

To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/us3lims_gridctl/settings/notifications