[us-commits] [ehb54/us3lims_gridctl] 7314df: Detect job submission failures in submitone.php's ...

[emre brookes]

  Branch: refs/heads/ehb54-issue-917
  Home:   https://github.com/ehb54/us3lims_gridctl
  Commit: 7314df59df76c69f5b7650b1f79273e98c855fdc
      https://github.com/ehb54/us3lims_gridctl/commit/7314df59df76c69f5b7650b1f79273e98c855fdc
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-06-22 (Mon, 22 Jun 2026)

  Changed paths:
    M submitone.php

  Log Message:
  -----------
  Detect job submission failures in submitone.php's CLI error checks

The included web pages (2DSA_1.php/2DSA_2.php, PCSA_1.php/PCSA_2.php,
etc.) never push job submission failures into $cli_errors themselves
- they only echo an ERROR: line into the dumped output. As a result,
submitone.php's check_cli_errors() saw an empty array and proceeded
as if the submission had succeeded, even when it hadn't (e.g. the
sbatch failure case fixed in ehb54/us3lims_common#21).

Add check_cli_errors_in_dump(), which scans the dump file for any
ERROR: line and folds it into $cli_errors, called right before
check_cli_errors() after both the PCSA and 2DSA job-type includes.

This doesn't change GMP/autoflow's own failure detection, which
already polls autoflowAnalysis.status directly - it only gives
submitone.php its own immediate signal that a submission it just ran
failed.

Fixes ehb54/ultrascan-tickets#917



To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/us3lims_gridctl/settings/notifications