Branch: refs/heads/ehb54-issue-984 Home: https://github.com/ehb54/ultrascan3 Commit: 7af0d35d528bfa46d51f00796442cdaf4053e1e1 https://github.com/ehb54/ultrascan3/commit/7af0d35d528bfa46d51f00796442cdaf4... Author: ehb54 <brookes@uthscsa.edu> Date: 2026-08-07 (Fri, 07 Aug 2026) Changed paths: M us_somo/develop/grpy/grpy_shell.hpp M us_somo/develop/grpy/tests/test_shell.cpp M us_somo/develop/include/us_hydrodyn.h M us_somo/develop/src/us_hydrodyn_grpy.cpp M us_somo/develop/src/us_hydrodyn_hydro.cpp M us_somo/somo/doc/manual/somo/somo_hydro.html Log Message: ----------- somo/grpy: show each shell model as it is made, and let Stop end the ladder Two changes that only make sense together. The shell models were written in a batch after the whole ladder finished, which is the least useful moment: by then there is nothing left to decide. They are now written and displayed as each rung completes, so a shell that is obviously wrong can be seen while the calculation is still running. That is worth nothing unless the run can then be stopped, and it could not. stopFlag was consulted only inside the progress callback, where it skipped a UI update and nothing else -- pressing Stop did not end a running GRPY calculation at all. ShellOptions::should_stop is now checked between rungs and wired to stopFlag, so Stop ends the ladder at the end of the rung in progress. Since each rung costs roughly eight times the one before, stopping before the next begins saves nearly all of what remained. A stopped run keeps what it computed, reports its error bar, and is marked NOT converged -- the same treatment as a memory-capped one, and never passed off as if it had converged. Stopping before any rung ran leaves levels == 0 and no result, which the caller must detect, again as with the memory cap. Between rungs only: a rung already running goes to completion, since the solve has no interior abort. Adding one would mean threading cancellation through the factorization, which is a larger change for much less benefit. The per-rung write reads srep.kept.back() from the live report, which is sound because the module records each rung's selection before calling on_rung. Also widens the options window to 740 and lays the shell-reduction box out in two rows. That box carries six controls, about a hundred characters of label text -- half again the widest of the other boxes -- and was clipped on the right. Two rows drops what it demands to roughly a single row's width, so it survives larger fonts rather than merely clearing today's threshold; the width increase is headroom, not the fix. Fixes ehb54/ultrascan-tickets#984 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications