Branch: refs/heads/ehb54-issue-984 Home: https://github.com/ehb54/ultrascan3 Commit: e890967d575f7a8f9f5d487ac5ad6352207a0e4d https://github.com/ehb54/ultrascan3/commit/e890967d575f7a8f9f5d487ac5ad63522... Author: ehb54 <brookes@uthscsa.edu> Date: 2026-08-08 (Sat, 08 Aug 2026) Changed paths: M us_somo/develop/src/us_hydrodyn_hydro.cpp M us_somo/somo/doc/manual/somo/somo_hydro.html M us_somo/somo/doc/manual/somo/somo_hydro_shell_reduction.html Log Message: ----------- somo/grpy: name the shell viscosity checkbox for what it gates " Require intrinsic viscosity " read as an on/off switch for the quantity itself. Because a disabled checkbox keeps its setting, unchecking it with shell reduction on and then switching the reduction off left an unchecked, greyed-out box that looked as though viscosity had been turned off for ordinary GRPY runs too -- and could not be turned back on without re-enabling the reduction. It never was off, and no behaviour changes here. With shell reduction off, ShellSolver::run() returns on the unreduced path having set viscosity_unreliable false; that flag is additionally cleared at the start of every run, there is exactly one solver construction site so nothing bypasses it, and it is the only thing that withholds [eta] or the viscosity-derived Einstein radius from the reported results. The setting reaches nothing else: the result-file name suffix and the non-default-settings report are both gated on grpy_shell. So this is a naming fix. "to converge" says that the box governs when the series of calculations may stop, not whether the quantity is computed -- intrinsic viscosity comes from the same matrix as every other quantity, at no additional cost, and is therefore always computed. A tooltip states the same in the window itself, the first in this one, following the newer MALS/DAD screens. The manual had it right but under the old name. Both pages are renamed to match, and somo_hydro.html now says explicitly that the checkbox bears only on the stopping decision, that the quantity is always computed, and that the retained setting has no effect at all while the option is off. Fixes ehb54/ultrascan-tickets#984 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications