[ehb54/us3lims_dbinst] b7b60f: Surface job submission failures on the "job accept...
Branch: refs/heads/main Home: https://github.com/ehb54/us3lims_dbinst Commit: b7b60f199f538f4030991ea44b06cd0ab7e4b765 https://github.com/ehb54/us3lims_dbinst/commit/b7b60f199f538f4030991ea44b06c... Author: ehb54 <brookes@uthscsa.edu> Date: 2026-06-22 (Mon, 22 Jun 2026) Changed paths: M 2DSA-CG_2.php M 2DSA_2.php M DMGA_2.php M GA_3.php M PCSA_2.php Log Message: ----------- Surface job submission failures on the "job accepted" confirmation page 2DSA_2.php, 2DSA-CG_2.php, PCSA_2.php, GA_3.php, and DMGA_2.php each print a "Thank you, your job was accepted and is currently processing" banner unconditionally, before checking the submit class's messages. If submission actually failed (e.g. the sbatch failure case fixed in ehb54/us3lims_common#21), the only sign was an ERROR: line buried in a raw print_r() dump below the success banner. Scan the queue messages for an ERROR: line (the prefix used by submit_local.php's failure path) and surface a clear, visible warning when found, without changing any existing control flow. Fixes ehb54/ultrascan-tickets#916 Commit: 19e67efb6cd2821d04e65867e39e436ed8b44be4 https://github.com/ehb54/us3lims_dbinst/commit/19e67efb6cd2821d04e65867e39e4... Author: emre brookes <ehb54@users.noreply.github.com> Date: 2026-06-22 (Mon, 22 Jun 2026) Changed paths: M 2DSA-CG_2.php M 2DSA_2.php M DMGA_2.php M GA_3.php M PCSA_2.php Log Message: ----------- Merge pull request #60 from ehb54/ehb54-issue-916 Surface job submission failures on the "job accepted" confirmation page Compare: https://github.com/ehb54/us3lims_dbinst/compare/222415c8a278...19e67efb6cd2 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/us3lims_dbinst/settings/notifications
participants (1)
-
emre brookes