[ehb54/us3lims_gridctl] 7314df: Detect job submission failures in submitone.php's ...
Branch: refs/heads/main Home: https://github.com/ehb54/us3lims_gridctl Commit: 7314df59df76c69f5b7650b1f79273e98c855fdc https://github.com/ehb54/us3lims_gridctl/commit/7314df59df76c69f5b7650b1f792... Author: ehb54 <brookes@uthscsa.edu> Date: 2026-06-22 (Mon, 22 Jun 2026) Changed paths: M submitone.php Log Message: ----------- Detect job submission failures in submitone.php's CLI error checks The included web pages (2DSA_1.php/2DSA_2.php, PCSA_1.php/PCSA_2.php, etc.) never push job submission failures into $cli_errors themselves - they only echo an ERROR: line into the dumped output. As a result, submitone.php's check_cli_errors() saw an empty array and proceeded as if the submission had succeeded, even when it hadn't (e.g. the sbatch failure case fixed in ehb54/us3lims_common#21). Add check_cli_errors_in_dump(), which scans the dump file for any ERROR: line and folds it into $cli_errors, called right before check_cli_errors() after both the PCSA and 2DSA job-type includes. This doesn't change GMP/autoflow's own failure detection, which already polls autoflowAnalysis.status directly - it only gives submitone.php its own immediate signal that a submission it just ran failed. Fixes ehb54/ultrascan-tickets#917 Commit: 5d00d5db8381168ffca0014e20c8e48ce3d7402a https://github.com/ehb54/us3lims_gridctl/commit/5d00d5db8381168ffca0014e20c8... Author: emre brookes <ehb54@users.noreply.github.com> Date: 2026-06-22 (Mon, 22 Jun 2026) Changed paths: M submitone.php Log Message: ----------- Merge pull request #27 from ehb54/ehb54-issue-917 Detect job submission failures in submitone.php's CLI error checks Compare: https://github.com/ehb54/us3lims_gridctl/compare/31337ffaf7ae...5d00d5db8381 To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/us3lims_gridctl/settings/notifications
participants (1)
-
emre brookes