[us-commits] [ehb54/ultrascan3] 005210: Address PR #335 review feedback from doluk

[emre brookes]

  Branch: refs/heads/somo-qt6
  Home:   https://github.com/ehb54/ultrascan3
  Commit: 005210ec1222cf2098477fef7cbc62cdfdb1c08b
      https://github.com/ehb54/ultrascan3/commit/005210ec1222cf2098477fef7cbc62cdfdb1c08b
  Author: ehb54 <brookes at uthscsa.edu>
  Date:   2026-07-01 (Wed, 01 Jul 2026)

  Changed paths:
    M us_somo/develop/3dplot/lightingdlgbase.h
    M us_somo/develop/src/us3i_gui_util.cpp
    M us_somo/develop/src/us_config.cpp
    M us_somo/develop/src/us_hydrodyn.cpp
    M us_somo/develop/src/us_hydrodyn_addresidue.cpp
    M us_somo/develop/src/us_hydrodyn_anaflex_core.cpp
    M us_somo/develop/src/us_hydrodyn_bd_core.cpp
    M us_somo/develop/src/us_hydrodyn_beads_load.cpp
    M us_somo/develop/src/us_hydrodyn_best.cpp

  Log Message:
  -----------
  Address PR #335 review feedback from doluk

- Qt::WFlags -> Qt::WindowFlags (lightingdlgbase.h)
- inline the const-wrapper save_svg overload (us3i_gui_util.cpp)
- drop dead Qt3/4 QT_VERSION include guard (us_config.cpp)
- hoist repeated regex construction to static const in
  fileNameCheck (us_hydrodyn.cpp), anaflex txt-extension checks
  (us_hydrodyn_anaflex_core.cpp), and the leading-'=' strip in
  US_Hydrodyn_Best::load (us_hydrodyn_best.cpp)
- move QRegularExpression include next to other Qt includes and
  simplify rx_spaces construction (us_hydrodyn_addresidue.cpp)
- remove duplicate QRegularExpression include (us_hydrodyn_bd_core.cpp)
- combine QRegularExpression rx construction with its pattern and
  drop the now-redundant setPattern call (us_hydrodyn_beads_load.cpp)



To unsubscribe from these emails, change your notification settings at https://github.com/ehb54/ultrascan3/settings/notifications